eslint 9 + vulnerabilities#54
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Migrates the project’s linting setup to ESLint v9 (flat config) while updating related dev dependencies, and applies small code/test adjustments to align with the new linting constraints.
Changes:
- Upgrade ESLint to v9 and eslint-plugin-github to v6, plus Vitest-related dev dependency bumps.
- Replace legacy
.eslintrc.jsonwith a neweslint.config.mjsflat config (including ignore + per-path rule overrides). - Minor test/code tweaks (e.g., optional catch binding; removal of inline eslint-disable comments).
Show a summary per file
| File | Description |
|---|---|
test/test.spec.js |
Removes an unused catch binding and drops an inline eslint-disable comment. |
src/index.ts |
Drops an inline eslint-disable comment near an empty catch handler in the submit flow. |
package.json |
Updates ESLint/vitest-related devDependencies and removes eslintIgnore in favor of flat config ignores. |
eslint.config.mjs |
Adds ESLint v9 flat config equivalent of the previous .eslintrc.json rules/overrides. |
.eslintrc.json |
Removes legacy config now replaced by eslint.config.mjs. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 5/6 changed files
- Comments generated: 1
Comment on lines
160
to
163
| remoteSubmit(req) | ||
| .then(ultimateResolve, ultimateReject) | ||
| // eslint-disable-next-line @typescript-eslint/no-empty-function | ||
| .catch(() => {}) | ||
| .then(() => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.