Skip to content

config: eliminate duplicate body between UnsupportedField and InvalidValue #8097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 3 commits into from
Jun 26, 2026
+0 −0
Merged

config: eliminate duplicate body between UnsupportedField and InvalidValue #8097

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bdfbb19
Initial plan
Copilot Jun 25, 2026
db102cb
fix: make UnsupportedField an alias for InvalidValue to eliminate dup…
Copilot Jun 25, 2026
7da6d07
Merge remote-tracking branch 'origin/main' into copilot/duplicate-cod…
Copilot Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions internal/config/validation_errors.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,11 @@ func MissingRequired(fieldName, serverType, jsonPath, suggestion string) *Valida
}
}

// UnsupportedField creates a ValidationError for unsupported fields
// UnsupportedField creates a ValidationError for unsupported or unrecognized fields.
// Alias for InvalidValue; retained for semantic clarity at call sites where the
// error is about an unexpected field rather than a constraint violation.
func UnsupportedField(fieldName, message, jsonPath, suggestion string) *ValidationError {
return &ValidationError{
Field: fieldName,
Message: message,
JSONPath: jsonPath,
Suggestion: suggestion,
}
return InvalidValue(fieldName, message, jsonPath, suggestion)
}

// AppendConfigDocsFooter appends standard documentation links to an error message
Expand Down
Loading