Generate methods with untyped records as container-transfer return values - #1328
Open
ousnius wants to merge 1 commit into
Open
Generate methods with untyped records as container-transfer return values#1328ousnius wants to merge 1 commit into
ousnius wants to merge 1 commit into
Conversation
Member
|
The generated xml looks like this: <function name="returns_transfer_container"
c:identifier="girtest_untyped_record_tester_returns_transfer_container"
introspectable="0">
<source-position filename="girtest-untyped-record-tester.h" line="40"/>
<return-value>
<type name="UntypedRecordContainerTester"
c:type="GirTestUntypedRecordContainerTester*"/>
</return-value>
</function>
If you want to see if scenarios similar to As
<return-value transfer-ownership="container">
<doc xml:space="preserve"
filename="gdk-pixbuf/gdk-pixbuf-io.c"
line="3432">A list of
support image formats.</doc>
<type name="GLib.SList" c:type="GSList*">
<type name="PixbufFormat"/>
</type>
</return-value>
|
ousnius
force-pushed
the
return-untyped-record-container
branch
from
September 26, 2025 14:35
4e36f15 to
3cbe3a2
Compare
ousnius
marked this pull request as ready for review
September 26, 2025 14:35
Member
|
These untyped records exist: |
Member
|
ousnius
marked this pull request as draft
September 28, 2025 10:08
badcel
reviewed
Feb 25, 2026
Contributor
Author
|
@badcel I committed a change to the tests that should now test what this PR is for (typed record).
Done: #1572 About your other comments, I think that can be done later and isn't a blocker for this PR.
The copy is a shallow byte copy:
Container release leaks non-head nodes. |
ousnius
marked this pull request as ready for review
July 26, 2026 10:04
1 task
…lues transfer-container is usually used with GLib.List and GLib.SList as return values. The ownership of the returned container is transferred, but the ownership of the elements in the container is not. Tested via a static method mirroring gdk_pixbuf_get_formats: it returns a GSList with transfer-container containing two static typed record elements that are owned by native code. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ousnius
force-pushed
the
return-untyped-record-container
branch
from
July 26, 2026 10:28
8d880c0 to
9b9c4b2
Compare
Member
|
Should wait for #1573 because it allows manual handling for untyped records. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
transfer-containeris usually used withGLib.ListandGLib.SListas return values.The ownership of the returned container is transferred, but the ownership of the elements in the container is not.
API examples:
gdk_pixbuf_get_formatsgtk_textiter_get_tagsAdded a test that returns a container with two static elements that are owned by native code.