Skip to content

Lock rank cleanup, part 2#9728

Open
andyleiserson wants to merge 5 commits into
gfx-rs:trunkfrom
andyleiserson:jj-push-ywrq
Open

Lock rank cleanup, part 2#9728
andyleiserson wants to merge 5 commits into
gfx-rs:trunkfrom
andyleiserson:jj-push-ywrq

Conversation

@andyleiserson

@andyleiserson andyleiserson commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Progress towards #5937. Part 1 was in #9524.

This fixes some violations of the lock rank graph:

Testing
No explicit testing in this PR, but at the tip of my branch, the lock validation build can pass our test suite, see #9479.

Squash or Rebase? Rebase

Checklist

  • I self-reviewed and fully understand this PR.
  • WebGPU implementations built with wgpu may be affected behaviorally.
  • Validation and feature gates are in place to confine behavioral changes.
  • Tests demonstrate the validation and altered logic works.
  • CHANGELOG.md entries for the user-facing effects of this change are present.
  • The PR is minimal, and doesn't make sense to land as multiple PRs.
  • Commits are logically scoped and individually reviewable.
  • The PR description has enough context to understand the motivation and solution implemented.

@andyleiserson

Copy link
Copy Markdown
Contributor Author

The purpose of the changes in memory_init.rs and queue.rs is to drop the initialization status lock before acquiring the tracker lock in clear_texture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deadlock between Queue::write_texture and Queue::submit via inconsistent ordering of trackers and Texture::initialization_status

2 participants