Reject stuff#9703
Draft
inner-daemons wants to merge 1 commit into
Draft
Conversation
8 tasks
Member
Like this PR title, could you add some more context to this please |
Contributor
|
We are also validating copy size for multi-planar textures incorrectly in some cases. It looks like some validation was added in #9551, but I only see |
Member
|
Drafting until this gets iterated on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Closes #9344
Description
Currently we allow creating texture views on multiplanar formats with
TextureAspect::All, which causes all kinds of problems, the least of which is validation errors. See Andy's comment.Testing
Not tested
Squash or Rebase?
Squash
Checklist
wgpumay be affected behaviorally.CHANGELOG.mdentries for the user-facing effects of this change are present.