Skip to content

Reject stuff#9703

Draft
inner-daemons wants to merge 1 commit into
gfx-rs:trunkfrom
inner-daemons:disallow-full-multiplanar-texture-view
Draft

Reject stuff#9703
inner-daemons wants to merge 1 commit into
gfx-rs:trunkfrom
inner-daemons:disallow-full-multiplanar-texture-view

Conversation

@inner-daemons

Copy link
Copy Markdown
Collaborator

Connections
Closes #9344

Description
Currently we allow creating texture views on multiplanar formats with TextureAspect::All, which causes all kinds of problems, the least of which is validation errors. See Andy's comment.

Testing
Not tested

Squash or Rebase?
Squash

Checklist

  • I self-reviewed and fully understand this PR.
  • WebGPU implementations built with wgpu may be affected behaviorally.
  • Validation and feature gates are in place to confine behavioral changes.
  • Tests demonstrate the validation and altered logic works.
  • CHANGELOG.md entries for the user-facing effects of this change are present.
  • The PR is minimal, and doesn't make sense to land as multiple PRs.
  • Commits are logically scoped and individually reviewable.
  • The PR description has enough context to understand the motivation and solution implemented.

@cwfitzgerald

Copy link
Copy Markdown
Member

Reject stuff

Like this PR title, could you add some more context to this please

@andyleiserson andyleiserson self-assigned this Jun 24, 2026
@andyleiserson

Copy link
Copy Markdown
Contributor

We are also validating copy size for multi-planar textures incorrectly in some cases. It looks like some validation was added in #9551, but I only see copy_texture_to_texture handled in that PR.

@cwfitzgerald

Copy link
Copy Markdown
Member

Drafting until this gets iterated on

@cwfitzgerald cwfitzgerald marked this pull request as draft July 7, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Creating texture view with TextureAspect::All on multi-planar texture causes validation errors

3 participants