Skip to content

mpg123: Update to 1.33.6#9434

Merged
HarveyDevel merged 1 commit into
mainfrom
update_mpg123_1336
Jun 29, 2026
Merged

mpg123: Update to 1.33.6#9434
HarveyDevel merged 1 commit into
mainfrom
update_mpg123_1336

Conversation

@clintre

@clintre clintre commented Jun 28, 2026

Copy link
Copy Markdown
Member

Summary

  • Security Update
  • moved to 64 bit
  • Added license

Security

  • Fix memory leak with --network internal due to inverted NULL check

Change Log

Test Plan

  • Play media
  • Test Audacity with mp3

Checklist

  • Package was built and tested against unstable
  • This change could gainfully be listed in the weekly sync notes once merged
  • I agree to license this contribution and all my previous contributions under the licensing terms in LICENSE.md and have the power and authority to grant those licenses.

@github-project-automation github-project-automation Bot moved this to Triage in Solus Jun 28, 2026
@clintre clintre added the Security Security issue label Jun 28, 2026

@HarveyDevel HarveyDevel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are 32bit builds no longer supported? That is a problem. We have packages depending on it such as steam (rundep) and sdl2-mixer (builddep), there may be more I stopped looking after that.

A lot of 32bit stuff exists for games. I assume steam is fine as it has its own bundled libs as part of its runtime but things outside of steam may break as happened with the deprecation of old libssl. I assume there would be major breakages for people with this change too.

Finally if this must be done the mpg123-32bit and mpg123-32bit-devel package should be deprecated.

@clintre

clintre commented Jun 29, 2026

Copy link
Copy Markdown
Member Author

I believe it can still do 32-bit. I will check and change.

@clintre clintre marked this pull request as draft June 29, 2026 01:10
**Summary**
- Security Update
- moved to 64 bit
- Added license

**Security**
- Fix memory leak with --network internal due to inverted NULL check

[Change Log](https://www.mpg123.de/cgi-bin/news.cgi)

**Test Plan**
- Play media
- Test Audacity with mp3
@clintre clintre force-pushed the update_mpg123_1336 branch from e4b3058 to b97ee1d Compare June 29, 2026 01:18
@clintre

clintre commented Jun 29, 2026

Copy link
Copy Markdown
Member Author

Ok, oversight on my part. It does, and I have corrected and tested.

@clintre clintre marked this pull request as ready for review June 29, 2026 01:20
@clintre clintre requested a review from HarveyDevel June 29, 2026 01:20

@HarveyDevel HarveyDevel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@HarveyDevel HarveyDevel merged commit a475c2c into main Jun 29, 2026
1 check passed
@HarveyDevel HarveyDevel deleted the update_mpg123_1336 branch June 29, 2026 01:35
@github-project-automation github-project-automation Bot moved this from Triage to Done in Solus Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Security Security issue

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants