Skip to content

chore(core): Implement disabled tracing semantics - #1286

Merged
szokeasaurusrex merged 4 commits into
szokeasaurusrex/chore/deprecate-is-sampledfrom
szokeasaurusrex/fix/fully-distinguish-disabled-tracing
Aug 31, 2026
Merged

chore(core): Implement disabled tracing semantics#1286
szokeasaurusrex merged 4 commits into
szokeasaurusrex/chore/deprecate-is-sampledfrom
szokeasaurusrex/fix/fully-distinguish-disabled-tracing

changelog entry and client report fix

8c40d88
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden completed Aug 31, 2026 in 0s

1 issue

Low

Span::is_sampled docs omit inherited sampled decision when tracing is disabled - `sentry-core/src/performance/mod.rs:1255-1258`

The Span::is_sampled documentation lists deferred tracing as the disabled-tracing case that returns false, but the implementation also returns false when tracing is disabled with an inherited Some(true) sampling decision. Clarify that disabled traces return false regardless of an inherited decision, or avoid enumerating the possible meanings.

2 skills analyzed
Skill Findings Duration Cost
security-review 0 2m $0.87
docs-review 1 7m 32s $1.10

⏱ 9m 32s · 1.2M in / 79.9k out · $1.97