Skip to content

#12570 - Fix: Dialog closes unexpectedly when selecting text#12575

Merged
tdipisa merged 2 commits into
geosolutions-it:masterfrom
dsuren1:#12570_fix
Jul 22, 2026
Merged

#12570 - Fix: Dialog closes unexpectedly when selecting text#12575
tdipisa merged 2 commits into
geosolutions-it:masterfrom
dsuren1:#12570_fix

Conversation

@dsuren1

@dsuren1 dsuren1 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Description

This PR fixes the unexpected closing of dialog when selecting text and releasing outside the dialog

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

Issue

What is the current behavior?

What is the new behavior?

  • Selecting text within the dialog and releasing the mouse outside the dialog does not trigger a clickout. As a result, the dialog remains open until the user explicitly clicks outside the dialog.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@dsuren1 dsuren1 added this to the 2026.02.01 milestone Jul 1, 2026
@dsuren1
dsuren1 requested a review from allyoucanmap July 1, 2026 15:36
@dsuren1 dsuren1 added the bug label Jul 1, 2026
@cla-bot cla-bot Bot added the CLA Ready label Jul 1, 2026
@dsuren1 dsuren1 added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jul 1, 2026
@allyoucanmap
allyoucanmap requested review from stefanocudini and removed request for allyoucanmap July 6, 2026 07:52
@dsuren1 dsuren1 linked an issue Jul 9, 2026 that may be closed by this pull request
Dialog closes unexpectedly when selecting text and releasing outside the dialog #12570
Open
1 task
@dsuren1 dsuren1 added backport 2026.02.xx and removed BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Jul 9, 2026
@tdipisa
tdipisa marked this pull request as draft July 21, 2026 14:35
@tdipisa

tdipisa commented Jul 21, 2026

Copy link
Copy Markdown
Member

Converted to draft waiting for 2026.02.00 to be out

@stefanocudini

stefanocudini commented Jul 22, 2026

Copy link
Copy Markdown
Member

@tdipisa tested and approved

@tdipisa
tdipisa marked this pull request as ready for review July 22, 2026 16:32
@tdipisa
tdipisa merged commit 3b6ed02 into geosolutions-it:master Jul 22, 2026
16 checks passed
@offtherailz offtherailz mentioned this pull request Jul 22, 2026
Merged
@offtherailz

offtherailz commented Jul 22, 2026

Copy link
Copy Markdown
Member

Successfully created backport PR for 2026.02.xx:

offtherailz added a commit that referenced this pull request Jul 22, 2026
@offtherailz @dsuren1
#12570 - Fix: Dialog closes unexpectedly when selecting text (#12575) (…
d32b447 
…#12720)

(cherry picked from commit 3b6ed02)

Co-authored-by: Suren <dsuren1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stefanocudini stefanocudini stefanocudini approved these changes

Assignees

@stefanocudini stefanocudini

Labels

backport 2026.02.xx bug CLA Ready

Projects

None yet

Milestone

2026.02.01

Development

Successfully merging this pull request may close these issues.

Dialog closes unexpectedly when selecting text and releasing outside the dialog

5 participants

@dsuren1 @tdipisa @stefanocudini @offtherailz @allyoucanmap