Pass metadataId to schematron

[tylerjmchugh]

Schematron validations currently receive a limited set of parameters from the validation pipeline. Custom schematron rules may require additional metadata context to perform validation reliably, but the metadata ID is not currently available to them.

This PR aims to fix this issue by passing metadataId from AbstractSchematronValidator to the generated schematron XSLT as a parameter.

This provides schematron implementations with a reliable way to identify the exact metadata record being validated and supports custom validation use cases that need access to record-specific context. In our case, this is used to distinguish between approved metadata and working copies when validating associated resources.

Checklist

• I have read the contribution guidelines
• Pull request provided for main branch, backports managed with label
• Good housekeeping of code, cleaning up comments, tests, and documentation
• Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
• Clean commit messages, longer verbose messages are encouraged
• API Changes are identified in commit messages
• Testing provided for features or enhancements using automatic tests
• User documentation provided for new features or enhancements in manual
• Build documentation provided for development instructions in README.md files
• Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

[jodygarnett]

So I can see the test, and metadataId being used in is xsl.

Q: Do any of the built-in schemas need to make use of metadataId?

Q: Or is this a change required for a regional schema plugin? If so perhaps we can link to a metadata101 issue

[tylerjmchugh]

So I can see the test, and metadataId being used in is xsl.

Q: Do any of the built-in schemas need to make use of metadataId?

Q: Or is this a change required for a regional schema plugin? If so perhaps we can link to a metadata101 issue

I don't think any of the built-in or plugin schemas require it currently. We have a custom schematron added to iso19139.ca.HNAP which does some validations on the resources but I am not aware of any existing schematrons that do similar.

[josegar74]

Changes look fine. Maybe to document in the manual the case for external validation, where -1 value is passed for metadata id and trying to use it will return an empty metadata:

core-geonetwork/core/src/main/java/org/fao/geonet/kernel/SchematronValidatorExternalMd.java

Line 60 in fdc2df4

runSchematron(lang, schemaDir, validations, schemaTronXmlOut, -1, md, applicable);

[tylerjmchugh]

Changes look fine. Maybe to document in the manual the case for external validation, where -1 value is passed for metadata id and trying to use it will return an empty metadata:

core-geonetwork/core/src/main/java/org/fao/geonet/kernel/SchematronValidatorExternalMd.java

Line 60 in fdc2df4

runSchematron(lang, schemaDir, validations, schemaTronXmlOut, -1, md, applicable);

@josegar74 Added a comment and documentation in the latest push