Use constants when possible#9412
Open
sebr72 wants to merge 1 commit into
Open
Conversation
sebr72
marked this pull request as ready for review
July 8, 2026 09:53
Contributor
Author
|
@josegar74 I did some research on the constants and here they are. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the constants based on https://github.com/Saxonica/Saxon-Archive/blob/main/Saxon-B/9.1.0.8/saxonb9-1-0-8source.zip
Checklist
I have read the contribution guidelines
Pull request provided for
mainbranch, backports managed with labelGood housekeeping of code, cleaning up comments, tests, and documentation
Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
Clean commit messages, longer verbose messages are encouraged
API Changes are identified in commit messages
Testing provided for features or enhancements using automatic tests
User documentation provided for new features or enhancements in manual
Build documentation provided for development instructions in
README.mdfilesLibrary management using
pom.xmldependency management. Update build documentation with intended library use and library tutorials or documentationFunded by Swisstopo