Logo improvements#9322
Quality Gate failed
Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
E Security Rating on New Code (required ≥ A)
C Reliability Rating on New Code (required ≥ A)
See analysis details on SonarQube Cloud
Catch issues before they fail your Quality Gate with our IDE extension
SonarQube for IDE
Annotations
Check warning on line 121 in core/src/main/java/org/fao/geonet/resources/FileResources.java
sonarqubecloud / SonarCloud Code Analysis
Change this code to not construct the path from user-controlled data.
See more on https://sonarcloud.io/project/issues?id=geonetwork_core-geonetwork&issues=AZ6r_zHqsFkeTS6Nl5Q8&open=AZ6r_zHqsFkeTS6Nl5Q8&pullRequest=9322
Check warning on line 46 in core/src/main/java/org/fao/geonet/resources/ResourceFilter.java
sonarqubecloud / SonarCloud Code Analysis
Remove this unused import 'java.util.List'.
See more on https://sonarcloud.io/project/issues?id=geonetwork_core-geonetwork&issues=AZ6r_zIzsFkeTS6Nl5RB&open=AZ6r_zIzsFkeTS6Nl5RB&pullRequest=9322
Check warning on line 863 in services/src/main/java/org/fao/geonet/api/site/SiteApi.java
sonarqubecloud / SonarCloud Code Analysis
Replace generic exceptions with specific library exceptions or a custom exception.
See more on https://sonarcloud.io/project/issues?id=geonetwork_core-geonetwork&issues=AZ6r_zEusFkeTS6Nl5Qw&open=AZ6r_zEusFkeTS6Nl5Qw&pullRequest=9322
Check failure on line 145 in core/src/main/java/org/fao/geonet/resources/FileResources.java
sonarqubecloud / SonarCloud Code Analysis
Change this code to not construct the path from user-controlled data.
See more on https://sonarcloud.io/project/issues?id=geonetwork_core-geonetwork&issues=AZ6r_zHqsFkeTS6Nl5Q5&open=AZ6r_zHqsFkeTS6Nl5Q5&pullRequest=9322
Check warning on line 92 in services/src/test/java/org/fao/geonet/api/sources/SourcesApiTest.java
sonarqubecloud / SonarCloud Code Analysis
Remove this use of "Assert"; it is deprecated.
See more on https://sonarcloud.io/project/issues?id=geonetwork_core-geonetwork&issues=AZ6r_y-zsFkeTS6Nl5Qr&open=AZ6r_y-zsFkeTS6Nl5Qr&pullRequest=9322
Check warning on line 936 in services/src/main/java/org/fao/geonet/api/site/SiteApi.java
sonarqubecloud / SonarCloud Code Analysis
Replace generic exceptions with specific library exceptions or a custom exception.
See more on https://sonarcloud.io/project/issues?id=geonetwork_core-geonetwork&issues=AZ6r_zEusFkeTS6Nl5Qx&open=AZ6r_zEusFkeTS6Nl5Qx&pullRequest=9322
Check failure on line 107 in core/src/main/java/org/fao/geonet/resources/ResourceFilter.java
sonarqubecloud / SonarCloud Code Analysis
Define a constant instead of duplicating this literal "images/logos/" 4 times.
See more on https://sonarcloud.io/project/issues?id=geonetwork_core-geonetwork&issues=AZ6r_zIzsFkeTS6Nl5Q_&open=AZ6r_zIzsFkeTS6Nl5Q_&pullRequest=9322
Check warning on line 196 in services/src/main/java/org/fao/geonet/api/sources/SourcesApi.java
sonarqubecloud / SonarCloud Code Analysis
Replace "@RequestMapping(method = RequestMethod.GET)" with "@GetMapping"
See more on https://sonarcloud.io/project/issues?id=geonetwork_core-geonetwork&issues=AZ6r_zHPsFkeTS6Nl5Q4&open=AZ6r_zHPsFkeTS6Nl5Q4&pullRequest=9322
Check warning on line 109 in core/src/main/java/org/fao/geonet/resources/FileResources.java
sonarqubecloud / SonarCloud Code Analysis
Change this code to not construct the path from user-controlled data.
See more on https://sonarcloud.io/project/issues?id=geonetwork_core-geonetwork&issues=AZ6r_zHqsFkeTS6Nl5Q9&open=AZ6r_zHqsFkeTS6Nl5Q9&pullRequest=9322
Check warning on line 38 in services/src/main/java/org/fao/geonet/api/groups/GroupsApi.java
sonarqubecloud / SonarCloud Code Analysis
Remove this unused import 'org.apache.commons.lang.StringUtils'.
See more on https://sonarcloud.io/project/issues?id=geonetwork_core-geonetwork&issues=AZ6r_zFbsFkeTS6Nl5Q0&open=AZ6r_zFbsFkeTS6Nl5Q0&pullRequest=9322
Check warning on line 913 in services/src/main/java/org/fao/geonet/api/site/SiteApi.java
sonarqubecloud / SonarCloud Code Analysis
Replace "@RequestMapping(method = RequestMethod.GET)" with "@GetMapping"
See more on https://sonarcloud.io/project/issues?id=geonetwork_core-geonetwork&issues=AZ6r_zEusFkeTS6Nl5Qy&open=AZ6r_zEusFkeTS6Nl5Qy&pullRequest=9322
Check warning on line 130 in core/src/main/java/org/fao/geonet/resources/FileResources.java
sonarqubecloud / SonarCloud Code Analysis
Change this code to not construct the path from user-controlled data.
See more on https://sonarcloud.io/project/issues?id=geonetwork_core-geonetwork&issues=AZ6r_zHqsFkeTS6Nl5Q-&open=AZ6r_zHqsFkeTS6Nl5Q-&pullRequest=9322
Check warning on line 859 in services/src/main/java/org/fao/geonet/api/site/SiteApi.java
sonarqubecloud / SonarCloud Code Analysis
Replace generic exceptions with specific library exceptions or a custom exception.
See more on https://sonarcloud.io/project/issues?id=geonetwork_core-geonetwork&issues=AZ6r_zEusFkeTS6Nl5Qv&open=AZ6r_zEusFkeTS6Nl5Qv&pullRequest=9322
Check warning on line 40 in services/src/main/java/org/fao/geonet/api/site/LogosApi.java
sonarqubecloud / SonarCloud Code Analysis
Remove this unused import 'org.fao.geonet.kernel.GeonetworkDataDirectory'.
See more on https://sonarcloud.io/project/issues?id=geonetwork_core-geonetwork&issues=AZ6r_zEHsFkeTS6Nl5Qu&open=AZ6r_zEHsFkeTS6Nl5Qu&pullRequest=9322
Check failure on line 139 in core/src/main/java/org/fao/geonet/resources/FileResources.java
sonarqubecloud / SonarCloud Code Analysis
Change this code to not construct the path from user-controlled data.
See more on https://sonarcloud.io/project/issues?id=geonetwork_core-geonetwork&issues=AZ6r_zHqsFkeTS6Nl5Q6&open=AZ6r_zHqsFkeTS6Nl5Q6&pullRequest=9322
Check warning on line 32 in core/src/main/java/org/fao/geonet/resources/ResourceFilter.java
sonarqubecloud / SonarCloud Code Analysis
Remove this unused import 'org.fao.geonet.domain.SourceType'.
See more on https://sonarcloud.io/project/issues?id=geonetwork_core-geonetwork&issues=AZ6r_zIzsFkeTS6Nl5RA&open=AZ6r_zIzsFkeTS6Nl5RA&pullRequest=9322
Check failure on line 36 in core/src/main/java/org/fao/geonet/resources/FileResources.java
sonarqubecloud / SonarCloud Code Analysis
Change this code to not construct the path from user-controlled data.
See more on https://sonarcloud.io/project/issues?id=geonetwork_core-geonetwork&issues=AZ6r_zHqsFkeTS6Nl5Q7&open=AZ6r_zHqsFkeTS6Nl5Q7&pullRequest=9322
sonarqubecloud / SonarCloud Code Analysis
Remove this use of "Assert"; it is deprecated.
See more on https://sonarcloud.io/project/issues?id=geonetwork_core-geonetwork&issues=AZ6r_zDisFkeTS6Nl5Qs&open=AZ6r_zDisFkeTS6Nl5Qs&pullRequest=9322
Check warning on line 233 in services/src/main/java/org/fao/geonet/api/sources/SourcesApi.java
sonarqubecloud / SonarCloud Code Analysis
Replace generic exceptions with specific library exceptions or a custom exception.
See more on https://sonarcloud.io/project/issues?id=geonetwork_core-geonetwork&issues=AZ6r_zHPsFkeTS6Nl5Q3&open=AZ6r_zHPsFkeTS6Nl5Q3&pullRequest=9322
Check warning on line 37 in services/src/main/java/org/fao/geonet/api/groups/GroupsApi.java
sonarqubecloud / SonarCloud Code Analysis
Remove this unused import 'org.apache.commons.io.FileUtils'.
See more on https://sonarcloud.io/project/issues?id=geonetwork_core-geonetwork&issues=AZ6r_zFbsFkeTS6Nl5Qz&open=AZ6r_zFbsFkeTS6Nl5Qz&pullRequest=9322
Check warning on line 182 in services/src/main/java/org/fao/geonet/api/harvesting/HarvestersApi.java
sonarqubecloud / SonarCloud Code Analysis
Replace "@RequestMapping(method = RequestMethod.GET)" with "@GetMapping"
See more on https://sonarcloud.io/project/issues?id=geonetwork_core-geonetwork&issues=AZ6r_zGwsFkeTS6Nl5Q2&open=AZ6r_zGwsFkeTS6Nl5Q2&pullRequest=9322
Check warning on line 195 in services/src/main/java/org/fao/geonet/api/harvesting/HarvestersApi.java
sonarqubecloud / SonarCloud Code Analysis
Replace generic exceptions with specific library exceptions or a custom exception.
See more on https://sonarcloud.io/project/issues?id=geonetwork_core-geonetwork&issues=AZ6r_zGwsFkeTS6Nl5Q1&open=AZ6r_zGwsFkeTS6Nl5Q1&pullRequest=9322
Check warning on line 534 in web/src/main/java/org/fao/geonet/Geonetwork.java
sonarqubecloud / SonarCloud Code Analysis
Remove this "break" statement or make it conditional.
See more on https://sonarcloud.io/project/issues?id=geonetwork_core-geonetwork&issues=AZ6r_zJZsFkeTS6Nl5RC&open=AZ6r_zJZsFkeTS6Nl5RC&pullRequest=9322
sonarqubecloud / SonarCloud Code Analysis
Remove this unused import 'org.springframework.test.web.servlet.result.MockMvcResultMatchers.content'.
See more on https://sonarcloud.io/project/issues?id=geonetwork_core-geonetwork&issues=AZ6r_zDjsFkeTS6Nl5Qt&open=AZ6r_zDjsFkeTS6Nl5Qt&pullRequest=9322