Allow Editor and Reviewer profiles to transfer record ownership

[juanluisrp]

Summary

• Editor users can now transfer ownership of records they own to any user within their own groups.
• Reviewer users can transfer ownership of records belonging to their groups to any user within their groups.
• The /users/groups endpoint now returns group members for Editor and Reviewer profiles (previously restricted to UserAdmin+), which is required to populate the transfer-ownership dialog.
• UI visibility guards in selection-widget.html and mdactionmenu.html are relaxed from isUserAdminOrMore() to isEditorOrMore().

Test plan

• Login as an Editor; verify the "Transfer ownership" action appears for owned records.
• Transfer an owned record to another user in the same group — should succeed.
• Attempt to transfer a record owned by another user — should be blocked (not editable).
• Attempt to transfer to a group the Editor does not belong to — should be blocked.
• Login as a Reviewer; verify the action appears for records in their group.
• Transfer a group record to another user in the same group — should succeed.
• Login as a plain Editor and call GET /srv/api/users/groups — should return users from their groups.
• Integration tests (MetadataSharingApiTest) pass.

[josegar74]

@juanluisrp I would refactor a bit the code of the changes:

   private boolean isEditableMetadata(AbstractMetadata metadata, AccessManager accessMan, UserSession callerSession) throws Exception {
        Profile callerProfile = callerSession.getProfile();
        
        if (callerProfile == Profile.Editor || callerProfile == Profile.Reviewer) {
            int callerUserId = callerSession.getUserIdAsInt();
            Integer sourceUsr = metadata.getSourceInfo().getOwner();
            Integer sourceGrp = metadata.getSourceInfo().getGroupOwner();

            if (callerProfile == Profile.Editor) {
                if (!Objects.equals(sourceUsr, callerUserId)) {
                    return false;
                }
            } else {
                Set<Integer> reviewerGroups = accessMan.getReviewerGroups(callerSession);
                if (sourceGrp == null || !reviewerGroups.contains(sourceGrp)) {
                    return false;
                }
            }

           return true;
        } else if (callerProfile == Profile.Administrator) {
            return true;
        } else {
            return false;
        }
    }

    private boolean isDestinationTransferGroupAllowed(Integer groupIdentifier, UserSession callerSession) {
        Profile callerProfile = callerSession.getProfile();

        if (callerProfile == Profile.Editor || callerProfile == Profile.Reviewer) {
            int callerUserId = callerSession.getUserIdAsInt();

            if (!ReservedGroup.isReserved(groupIdentifier)) {
                List<Integer> myGroups = userGroupRepository.findGroupIds(
                    UserGroupSpecs.hasUserId(callerUserId));
                if (!myGroups.contains(groupIdentifier)) {
                    return false;
                }
            }

            return true;
        } else if (callerProfile == Profile.Administrator) {
            return true;
        } else {
            return false;
        }
    }

...
            UserSession callerSession = ApiUtils.getUserSession(session);

            if (!isEditableMetadata(metadata, accessMan, callerSession)) {
                report.addNotEditableMetadataId(metadata.getId());
                return;
            }

            if (!isDestinationTransferGroupAllowed(groupIdentifier, callerSession)) {
                report.addMetadataInfos(metadata,
                    "Transfer to group " + groupIdentifier + " is not allowed for your profile.");
                return;
            }

            // Retrieve the identifiers associated with the metadata uuid.
            // When the workflow is enabled, the metadata can have an approved and a working copy version.
...

[josegar74]

I would refactor, with previous lines also:

    private List<UserGroupsResponse> getUserGroupsResponse(List<UserGroup> userGroups, List<GroupType> groupTypes) {
        List<UserGroupsResponse> list =  new ArrayList<>();

        if (groupTypes != null) {
            userGroups = userGroups.stream()
                .filter(ug -> groupTypes.contains(ug.getGroup().getType()))
                .collect(Collectors.toList());
        }

        for (UserGroup ug : userGroups) {
            list.add(new UserGroupsResponse(ug.getUser(), ug.getGroup(), ug.getProfile().name()));
        }

        return list;
    }

...
           list.addAll(getUserGroupsResponse(userGroups, groupTypes));
            
            return list;

        } else if (myProfile == Profile.Reviewer || myProfile == Profile.Editor) {
            List<Integer> myGroups = userGroupRepository.findAll(UserGroupSpecs.hasUserId(session.getUserIdAsInt()))
                .stream().map(ug -> ug.getGroup().getId()).collect(Collectors.toList());
            List<UserGroup> userGroups = userGroupRepository.findAll(UserGroupSpecs.hasGroupIds(myGroups));

            return getUserGroupsResponse(userGroups, groupTypes);
        } else {
            throw new SecurityException("You don't have rights to do get the groups for this user");
        }
...

[josegar74]

@juanluisrp I would refactor a bit the code of the changes:

   private boolean isEditableMetadata(AbstractMetadata metadata, AccessManager accessMan, UserSession callerSession) throws Exception {
        Profile callerProfile = callerSession.getProfile();
        
        if (callerProfile == Profile.Editor || callerProfile == Profile.Reviewer) {
            int callerUserId = callerSession.getUserIdAsInt();
            Integer sourceUsr = metadata.getSourceInfo().getOwner();
            Integer sourceGrp = metadata.getSourceInfo().getGroupOwner();

            if (callerProfile == Profile.Editor) {
                if (!Objects.equals(sourceUsr, callerUserId)) {
                    return false;
                }
            } else {
                Set<Integer> reviewerGroups = accessMan.getReviewerGroups(callerSession);
                if (sourceGrp == null || !reviewerGroups.contains(sourceGrp)) {
                    return false;
                }
            }
        } else if (callerProfile == Profile.Administrator) {
            return true;
        }
        
        return false;
    }

    private boolean isDestinationTransferGroupAllowed(Integer groupIdentifier, UserSession callerSession) {
        Profile callerProfile = callerSession.getProfile();

        if (callerProfile == Profile.Editor || callerProfile == Profile.Reviewer) {
            int callerUserId = callerSession.getUserIdAsInt();

            if (!ReservedGroup.isReserved(groupIdentifier)) {
                List<Integer> myGroups = userGroupRepository.findGroupIds(
                    UserGroupSpecs.hasUserId(callerUserId));
                if (!myGroups.contains(groupIdentifier)) {
                    return false;
                }
            }

            return true;
        } else if (callerProfile == Profile.Administrator) {
            return true;
        }
        
        return false;
    }

...
            UserSession callerSession = ApiUtils.getUserSession(session);

            if (!isEditableMetadata(metadata, accessMan, callerSession)) {
                report.addNotEditableMetadataId(metadata.getId());
                return;
            }

            if (!isDestinationTransferGroupAllowed(groupIdentifier, callerSession)) {
                report.addMetadataInfos(metadata,
                    "Transfer to group " + groupIdentifier + " is not allowed for your profile.");
                return;
            }

            // Retrieve the identifiers associated with the metadata uuid.
            // When the workflow is enabled, the metadata can have an approved and a working copy version.
...

[josegar74]

@juanluisrp I would refactor a bit the code of the changes:

   private boolean isEditableMetadata(AbstractMetadata metadata, AccessManager accessMan, UserSession callerSession) throws Exception {
        Profile callerProfile = callerSession.getProfile();
        
        if (callerProfile == Profile.Editor || callerProfile == Profile.Reviewer) {
            int callerUserId = callerSession.getUserIdAsInt();
            Integer sourceUsr = metadata.getSourceInfo().getOwner();
            Integer sourceGrp = metadata.getSourceInfo().getGroupOwner();

            if (callerProfile == Profile.Editor) {
                if (!Objects.equals(sourceUsr, callerUserId)) {
                    return false;
                }
            } else {
                Set<Integer> reviewerGroups = accessMan.getReviewerGroups(callerSession);
                if (sourceGrp == null || !reviewerGroups.contains(sourceGrp)) {
                    return false;
                }
            }
        } else if (callerProfile == Profile.Administrator) {
            return true;
        }
        
        return false;
    }

    private boolean isDestinationTransferGroupAllowed(Integer groupIdentifier, UserSession callerSession) {
        Profile callerProfile = callerSession.getProfile();

        if (callerProfile == Profile.Editor || callerProfile == Profile.Reviewer) {
            int callerUserId = callerSession.getUserIdAsInt();

            if (!ReservedGroup.isReserved(groupIdentifier)) {
                List<Integer> myGroups = userGroupRepository.findGroupIds(
                    UserGroupSpecs.hasUserId(callerUserId));
                if (!myGroups.contains(groupIdentifier)) {
                    return false;
                }
            }

            return true;
        } else if (callerProfile == Profile.Administrator) {
            return true;
        } else {
            return false;
        }
    }

...
            UserSession callerSession = ApiUtils.getUserSession(session);

            if (!isEditableMetadata(metadata, accessMan, callerSession)) {
                report.addNotEditableMetadataId(metadata.getId());
                return;
            }

            if (!isDestinationTransferGroupAllowed(groupIdentifier, callerSession)) {
                report.addMetadataInfos(metadata,
                    "Transfer to group " + groupIdentifier + " is not allowed for your profile.");
                return;
            }

            // Retrieve the identifiers associated with the metadata uuid.
            // When the workflow is enabled, the metadata can have an approved and a working copy version.
...