system-local-login: move pam_gnome_keyring after system-login if systemd - #28
Closed
Flowdalic wants to merge 1 commit into
Closed
system-local-login: move pam_gnome_keyring after system-login if systemd#28Flowdalic wants to merge 1 commit into
Flowdalic wants to merge 1 commit into
Conversation
We previously moved pam_gnome_keyring before system-login to fix an issue when using OpenRC (bug #964268). However, having pam_gnome_keyring before system-login, and thereby before pam_systemd, breaks automatic keyring unlock via pam_gnome_keyring on systemd systems (bug #964306). This adjusts the ninja template so that pam_gnome_keyring is only before system-login if --openrc is provided. Otherwise, pam_gnome_keyring is placed after system-login, just as it was before a507d2e ("system-local-login: move pam_gnome_keyring before system-login"). Thanks to Christopher Head for reporting this. Closes: https://bugs.gentoo.org/964306 Signed-off-by: Florian Schmaus <flow@gentoo.org>
|
This patch works for me—it changes the output file to be identical to the one I hand-edited to get GKR working. |
Member
Author
Thanks for testing the patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously moved pam_gnome_keyring before system-login to fix an issue when using OpenRC (bug #964268). However, having pam_gnome_keyring before system-login, and thereby before pam_systemd, breaks automatic keyring unlock via pam_gnome_keyring on systemd systems (bug #964306).
This adjusts the ninja template so that pam_gnome_keyring is only before system-login if --openrc is provided. Otherwise, pam_gnome_keyring is placed after system-login, just as it was before a507d2e ("system-local-login: move pam_gnome_keyring before system-login").
Thanks to Christopher Head for reporting this.
Closes: https://bugs.gentoo.org/964306