Skip to content

chore: update claude model selector #2742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janburzinski wants to merge 4 commits into
base: main
Choose a base branch
from
+17 −13
Open

chore: update claude model selector #2742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
350fb61
feat(claude): update model selector
janburzinski Jul 1, 2026
bb24084
fix(claude): prioritize fable model
janburzinski Jul 1, 2026
20a7729
chore(ui): restore story model order
janburzinski Jul 1, 2026
dff8fab
chore(ui): revert story model updates
janburzinski Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions apps/emdash-desktop/src/shared/core/conversations/conversation-config.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@ describe('conversation-config v1 schema', () => {
version: '1',
type: 'pty',
autoApprove: true,
model: 'claude-sonnet-4-5',
model: 'claude-sonnet-5',
});
expect(result.status).toBe('ok');
if (result.status === 'ok') {
expect(result.data).toEqual({
version: '1',
type: 'pty',
autoApprove: true,
model: 'claude-sonnet-4-5',
model: 'claude-sonnet-5',
});
}
});
Expand All @@ -24,26 +24,26 @@ describe('conversation-config v1 schema', () => {
const result = conversationConfig.safeParse({
version: '1',
type: 'acp',
model: 'claude-opus-4-5',
model: 'claude-opus-4-8',
});
expect(result.status).toBe('ok');
if (result.status === 'ok') {
expect(result.data).toEqual({ version: '1', type: 'acp', model: 'claude-opus-4-5' });
expect(result.data).toEqual({ version: '1', type: 'acp', model: 'claude-opus-4-8' });
}
});

it('upgrades a v0 legacy row (no version field) to v1 pty', () => {
const result = conversationConfig.safeParse({
autoApprove: true,
model: 'claude-sonnet-4-5',
model: 'claude-sonnet-5',
});
expect(result.status).toBe('ok');
if (result.status === 'ok') {
expect(result.data).toEqual({
version: '1',
type: 'pty',
autoApprove: true,
model: 'claude-sonnet-4-5',
model: 'claude-sonnet-5',
});
}
});
Expand Down Expand Up @@ -97,10 +97,10 @@ describe('conversation-config v1 schema', () => {
});

it('parses and round-trips model field on v0 input (upgraded to v1)', () => {
const result = conversationConfig.safeParse({ model: 'claude-sonnet-4-5' });
const result = conversationConfig.safeParse({ model: 'claude-sonnet-5' });
expect(result.status).toBe('ok');
if (result.status === 'ok') {
expect(result.data.model).toBe('claude-sonnet-4-5');
expect(result.data.model).toBe('claude-sonnet-5');
}
});
});
2 changes: 1 addition & 1 deletion apps/emdash-desktop/src/shared/core/conversations/conversation-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const conversationConfigV0Schema = z.object({
/** @deprecated Moved to conversations.session_id column; stripped on upgrade to v1. */
providerSessionId: z.string().optional(),
initialPrompt: z.string().optional(),
/** Model to pass to the agent CLI (e.g. 'claude-sonnet-4-5', 'o4-mini'). Empty string or absent = CLI default. */
/** Model to pass to the agent CLI (e.g. 'claude-sonnet-5', 'o4-mini'). Empty string or absent = CLI default. */
model: z.string().optional(),
});

Expand Down
12 changes: 8 additions & 4 deletions packages/plugins/src/agents/impl/claude/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,16 @@ export const plugin = definePlugin(
models: {
kind: 'selectable',
modelOptions: {
'claude-opus-4-5': {
name: 'Claude Opus 4.5',
'claude-fable-5': {
name: 'Claude Fable 5',
modelFeatures: { intelligence: 4, speed: 3 },
},
'claude-opus-4-8': {
name: 'Claude Opus 4.8',
modelFeatures: { intelligence: 5, speed: 2 },
},
'claude-sonnet-4-5': {
name: 'Claude Sonnet 4.5',
'claude-sonnet-5': {
name: 'Claude Sonnet 5',
modelFeatures: { intelligence: 4, speed: 4 },
},
'claude-haiku-4-5': {
Expand Down
Loading