-
Notifications
You must be signed in to change notification settings - Fork 524
fix: windows dev setup #2710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
janburzinski
wants to merge
4
commits into
main
Choose a base branch
from
emdash/dev-fail-fix-faqrg
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+64
−6
Open
fix: windows dev setup #2710
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
2a00775
fix(dev): use cross-env for debug scripts
janburzinski 6be2a20
fix(dev): make maintenance scripts cross-platform
janburzinski b217dd5
fix(dev): clean electron build output
janburzinski b6ca469
fix(dev): reset macos dev database path
janburzinski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import { rmSync } from 'node:fs'; | ||
|
|
||
| // Cross-platform replacement for `rm -rf node_modules dist`, which only ran on | ||
| // POSIX shells. The build output lives in `out/` (electron-vite default), not | ||
| // `dist/`, so wipe that. `rmSync` with recursive+force is a no-op when a target | ||
| // is missing. | ||
| for (const target of ['node_modules', 'out']) { | ||
| rmSync(target, { recursive: true, force: true }); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import { rmSync } from 'node:fs'; | ||
| import { homedir } from 'node:os'; | ||
| import { join } from 'node:path'; | ||
|
|
||
| // Cross-platform replacement for the old `rm -f` db:reset scripts, which only ran | ||
| // on POSIX shells. Wipes the dev SQLite databases (and their -wal/-shm sidecars) | ||
| // from the platform-specific userData directory. | ||
| const DEV_DIR_NAME = 'emdash-dev'; | ||
| const DB_BASENAMES = ['emdash3.db', 'emdash4.db']; | ||
|
|
||
| function devUserDataDir(): string { | ||
| const home = process.env.HOME ?? homedir(); | ||
|
|
||
| if (process.platform === 'darwin') { | ||
| return join(home, 'Library', 'Application Support', DEV_DIR_NAME); | ||
| } | ||
| if (process.platform === 'win32') { | ||
| const appData = process.env.APPDATA ?? join(home, 'AppData', 'Roaming'); | ||
| return join(appData, DEV_DIR_NAME); | ||
| } | ||
| const xdgConfig = process.env.XDG_CONFIG_HOME ?? join(home, '.config'); | ||
| return join(xdgConfig, DEV_DIR_NAME); | ||
| } | ||
|
|
||
| const dir = devUserDataDir(); | ||
| for (const base of DB_BASENAMES) { | ||
| for (const suffix of ['', '-wal', '-shm']) { | ||
| rmSync(join(dir, `${base}${suffix}`), { force: true }); | ||
| } | ||
| } | ||
|
|
||
| console.log(`db:reset: cleared dev databases in ${dir}`); | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.