Avoid mutable default arguments (#2501) - #2839
Open
HafizMHussain wants to merge 1 commit into
Open
Conversation
Per the Google Python style guide, mutable objects should not be used as default argument values. This fixes several occurrences by defaulting to None and initializing the mutable value inside the function body: - chart.py: image_histogram (reducer_args) - common.py: search_ee_data (keys), download_ee_image_tiles_parallel (job_args) - deck.py: Map.add_ee_layer (vis_params) - also removes the resolved TODO - plotlymap.py: Map.add_ee_layer (vis_params) deck.py and plotlymap.py already guarded against None internally, so those are signature/docstring updates only. Behavior is preserved; black and compile checks pass.
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes part of #2501.
Per the Google Python style guide,
mutable objects should not be used as default argument values. This PR fixes
a focused set of occurrences by defaulting to
Noneand initializing themutable value inside the function body:
chart.py:image_histogram(reducer_args)common.py:search_ee_data(keys),download_ee_image_tiles_parallel(job_args)deck.py:Map.add_ee_layer(vis_params) — also removes the now-resolvedTODOplotlymap.py:Map.add_ee_layer(vis_params)deck.pyandplotlymap.pyalready guarded againstNoneinternally, sothose are signature/docstring updates only. Behavior is preserved.
Verification:
black --checkpasses and all changed files compile.Scope note: This is a focused first pass. There are more occurrences
(mainly in
maplibregl.pyandtimelapse.py) that I'm happy to address ina follow-up PR if you'd like — kept this one small for easy review.