Add HMAC regression tests for Decimal key parsing#2680
Open
alleria173 wants to merge 1 commit into
Open
Conversation
alleria173
marked this pull request as ready for review
July 20, 2026 08:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds three HMAC regression tests covering Decimal-format key parsing with the fromDecimal "Auto" delimiter, as requested by a maintainer when closing #2650:
The underlying bug was fixed by the merge of #2270, so these tests pass against current master; they guard against future regressions of the Auto-delimiter behaviour. No operational code is changed — this PR only adds tests to [Hash.mjs]
Existing Issue
Relates to #2139 and #2217 (both resolved by #2270). Tests originally proposed in #2650 and split out into this stand-alone PR at a maintainer's request.
Screenshots
N/A — no visual changes.
AI disclosure
GitHub Copilot (Claude) was used to isolate these tests from the original PR branch and prepare this submission. The tests have been reviewed and verified manually.
Test Coverage
This PR consists entirely of test coverage. Full non-UI suite passes locally: 2244/2244 operation tests and 262/262 Node API tests.