Add pass-through result to ROT13 Brute Force#2677
Open
zhangli091011 wants to merge 1 commit into
Open
Conversation
zhangli091011
marked this pull request as ready for review
July 19, 2026 01:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Include the unmodified input as
Amount = 0in the ROT13 Brute Force output.This allows the operation to be chained with other brute-force operations without discarding candidates that do not require a rotation at the current step.
The pass-through uses amount zero rather than amount 26 because rotating numbers by 26 would not be a no-op.
Existing Issue
Fixes #2437
Screenshots
Not applicable. This change does not modify the UI.
AI disclosure
OpenCode was used to assist with repository analysis, implementation, and test preparation. The resulting changes and test results were reviewed locally.
Test Coverage
Added regression tests covering:
Amount = 0pass-through resultPrint amountdisabledValidation performed with Node.js 24.18.0:
npm test: 262 Node API tests and 2,243 operation tests passednpm run lint: passed with one pre-existing warning inFromDecimal.mjsnpm run node: passedgit diff --check: passedThe production Webpack build was attempted but is currently blocked on Windows by existing Jimp and BMFont loader errors unrelated to this change.