Skip to content

Add pass-through result to ROT13 Brute Force#2677

Open
zhangli091011 wants to merge 1 commit into
gchq:masterfrom
zhangli091011:fix/issue-2437-rot13-pass-through
Open

Add pass-through result to ROT13 Brute Force#2677
zhangli091011 wants to merge 1 commit into
gchq:masterfrom
zhangli091011:fix/issue-2437-rot13-pass-through

Conversation

@zhangli091011

Copy link
Copy Markdown

Description

Include the unmodified input as Amount = 0 in the ROT13 Brute Force output.

This allows the operation to be chained with other brute-force operations without discarding candidates that do not require a rotation at the current step.

The pass-through uses amount zero rather than amount 26 because rotating numbers by 26 would not be a no-op.

Existing Issue

Fixes #2437

Screenshots

Not applicable. This change does not modify the UI.

AI disclosure

OpenCode was used to assist with repository analysis, implementation, and test preparation. The resulting changes and test results were reviewed locally.

Test Coverage

Added regression tests covering:

  • the Amount = 0 pass-through result
  • letter and number pass-through behavior
  • sample offset and sample length handling
  • crib filtering
  • output with Print amount disabled

Validation performed with Node.js 24.18.0:

  • npm test: 262 Node API tests and 2,243 operation tests passed
  • npm run lint: passed with one pre-existing warning in FromDecimal.mjs
  • npm run node: passed
  • targeted ESLint: passed
  • git diff --check: passed

The production Webpack build was attempted but is currently blocked on Windows by existing Jimp and BMFont loader errors unrelated to this change.

@CLAassistant

CLAassistant commented Jul 19, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@zhangli091011
zhangli091011 marked this pull request as ready for review July 19, 2026 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: Rot N Bruteforce needs pass-through

2 participants