-
Notifications
You must be signed in to change notification settings - Fork 6
Add Action for validating package.xml files #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
eec235b
Add Action for validating package.xml files
42283b0
Add summary
d01219e
Use ament_xmllint
911e246
Update install command
3d9882d
Fix summary
88381e0
Use pip
a6e81ee
Needs xmllint
b741384
Correct dependency
0adce6a
Comment out ament_xmllint step
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| name: 'Validate package.xml' | ||
| description: 'Validate package.xml file' | ||
| runs: | ||
| using: "composite" | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: package.xml syntax validation | ||
| shell: bash | ||
| run: | | ||
| echo "Install ament-xmllint" | ||
| sudo apt-get install -y python3-venv libxml2-utils | ||
| python3 -m venv .venv | ||
| source .venv/bin/activate | ||
| pip install ament-xmllint | ||
| ament_xmllint package.xml 2>&1 | tee $GITHUB_STEP_SUMMARY | ||
|
|
||
| - name: package.xml and CMake versions match | ||
| shell: bash | ||
| run: | | ||
| echo "Extract version numbers and compare" | ||
| echo '## CMake and Package.xml Versions' >> $GITHUB_STEP_SUMMARY | ||
| package_xml_version=$(sed -nE 's/\s*<version>([0-9.]*)<\/version>\s*/\1/p' package.xml) | ||
| echo "Version in package.xml: ${package_xml_version}" | tee -a $GITHUB_STEP_SUMMARY | ||
| cmake_version=$(sed -nE 's/^project.*VERSION\s*([0-9.]*).*/\1/p' CMakeLists.txt) | ||
| echo "Version in CMake: ${cmake_version}" | tee -a $GITHUB_STEP_SUMMARY | ||
| [ $package_xml_version = $cmake_version ] | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.