Skip to content

Extract built-in vendor registry - #3075

Merged
gardener-prow[bot] merged 2 commits into
masterfrom
enh/vendor-registry
Jul 14, 2026
Merged

Extract built-in vendor registry#3075
gardener-prow[bot] merged 2 commits into
masterfrom
enh/vendor-registry

Conversation

@grolu

@grolu grolu commented Jul 14, 2026

Copy link
Copy Markdown
Member

What this PR does / why we need it:

This is the first preparatory refactor extracted from #2824.

It moves the built-in infrastructure, DNS, and machine-image vendor registries out of the configuration store and into dedicated modules under frontend/src/data/vendors.

Each infrastructure and DNS provider now has its own module, providing the foundation for moving additional provider-specific configuration out of application code in subsequent PRs.

This PR intentionally does not change:

  • vendor lookup or merge behavior
  • vendor names, display names, icons, weights, or ordering
  • shoot defaults
  • credential dialogs or Secret serialization
  • generated Gardener resources

The extracted registry objects are identical to the previous inline definitions.

Related PR:

Which issue(s) this PR fixes:

None.

Special notes for your reviewer:

Please review this as the first preparatory refactor in the sequential split of #2824. Follow-up PRs will build on these modules one concern at a time.

Validation:

  • make verify
  • Registry values compared with the previous inline definitions

Release note:

NONE

Summary by CodeRabbit

  • New Features
    • Added vendor listings for additional infrastructure providers, DNS services, and machine image distributions.
    • Added recognizable names, icons, and display ordering for each supported vendor.
    • Improved vendor selection consistency across infrastructure, DNS, and machine image options.

@gardener-prow

gardener-prow Bot commented Jul 14, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 14, 2026
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

An error occurred during the review process. Please try again later.

📝 Walkthrough

Walkthrough

Changes

Vendor metadata is extracted into reusable DNS, infrastructure, and machine-image data modules. Index modules aggregate the entries, and the configuration store imports these catalogs instead of defining the arrays inline.

Vendor catalog extraction

Layer / File(s) Summary
Vendor descriptor modules
frontend/src/data/vendors/dns/*, frontend/src/data/vendors/infra/*
DNS and infrastructure providers now export metadata objects containing identifiers, display names, weights, and icons.
Vendor catalog indexes
frontend/src/data/vendors/dns/index.js, frontend/src/data/vendors/infra/index.js, frontend/src/data/vendors/machineImage/index.js
DNS and infrastructure providers are aggregated into index arrays, and machine-image distributions are defined in a shared catalog.
Configuration store wiring
frontend/src/store/config.js
The store imports the shared vendor catalogs and references them from knownVendors instead of maintaining inline arrays.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes the main change: extracting the built-in vendor registry.
Description check ✅ Passed The description covers purpose, scope, related PR, notes, validation, and release note, but it omits the required /area and /kind categorization.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch enh/vendor-registry

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gardener-prow gardener-prow Bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 14, 2026
@grolu grolu added kind/enhancement Enhancement, improvement, extension area/quality Output qualification (tests, checks, scans, automation in general, etc.) related labels Jul 14, 2026
@gardener-prow gardener-prow Bot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Jul 14, 2026
@grolu
grolu marked this pull request as ready for review July 14, 2026 08:13
@grolu
grolu requested a review from a team as a code owner July 14, 2026 08:13
@gardener-prow gardener-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 14, 2026
@gardener-prow gardener-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 14, 2026

@petersutter petersutter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gardener-prow gardener-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2026
@gardener-prow

gardener-prow Bot commented Jul 14, 2026

Copy link
Copy Markdown

LGTM label has been added.

DetailsGit tree hash: cf53629adbfa4a507ab5f54f08908ca9bc576d30

@gardener-prow

gardener-prow Bot commented Jul 14, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petersutter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2026
@gardener-prow
gardener-prow Bot merged commit 5071289 into master Jul 14, 2026
26 checks passed
@gardener-prow
gardener-prow Bot deleted the enh/vendor-registry branch July 14, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/quality Output qualification (tests, checks, scans, automation in general, etc.) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants