Skip to content

Adding some comments on the function RECOG.SLn_godownfromd - #521

Open
Till-Eisen wants to merge 2 commits into
gap-packages:masterfrom
Till-Eisen:FindSL2inSLd
Open

Adding some comments on the function RECOG.SLn_godownfromd#521
Till-Eisen wants to merge 2 commits into
gap-packages:masterfrom
Till-Eisen:FindSL2inSLd

Conversation

@Till-Eisen

Copy link
Copy Markdown
Collaborator

As the title describes, I added some remarks for better understanding. I did not go into every detail though.

@Till-Eisen

Copy link
Copy Markdown
Collaborator Author

The function in question is used at the moment solely for d=4, i.e. the input group $g$ is isomorphic to $SL(4.q)$. If there are applications for the function for §d>q$ it would make sense to adjust the function in the following way:
Instead of searching random elements until $yy$ has order $q-1$, one could use either yy := y^(Order(y)/k) with k = lcd(order, q-1) or (If $d$ is to large to efficiently compute the order of $y$) yy := y^((q^(d-1)-1)/(q-1)).

@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.06%. Comparing base (28cfec8) to head (6a25cef).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #521      +/-   ##
==========================================
+ Coverage   86.42%   88.06%   +1.63%     
==========================================
  Files          45       45              
  Lines       19289    19291       +2     
==========================================
+ Hits        16671    16988     +317     
+ Misses       2618     2303     -315     
Files with missing lines Coverage Δ
gap/projective/sl.gi 98.41% <ø> (ø)

... and 14 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread gap/projective/sl.gi Outdated
Comment thread gap/projective/sl.gi Outdated
Comment thread gap/projective/sl.gi Outdated
Comment thread gap/projective/sl.gi
Comment on lines -310 to -313
#check that the action in 2 dimensions is SL(2,q)
#by non-constructive recognition, finding elements of
#order (q-1) and (q+1)
#we do not need memory in the group image

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove this comment?

@Till-Eisen Till-Eisen added the topic: classical groups related to recognition of classical groups label Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: classical groups related to recognition of classical groups

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants