Adding some comments on the function RECOG.SLn_godownfromd - #521
Open
Till-Eisen wants to merge 2 commits into
Open
Adding some comments on the function RECOG.SLn_godownfromd#521Till-Eisen wants to merge 2 commits into
Till-Eisen wants to merge 2 commits into
Conversation
Collaborator
Author
|
The function in question is used at the moment solely for d=4, i.e. the input group |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #521 +/- ##
==========================================
+ Coverage 86.42% 88.06% +1.63%
==========================================
Files 45 45
Lines 19289 19291 +2
==========================================
+ Hits 16671 16988 +317
+ Misses 2618 2303 -315
🚀 New features to boost your workflow:
|
Comment on lines
-310
to
-313
| #check that the action in 2 dimensions is SL(2,q) | ||
| #by non-constructive recognition, finding elements of | ||
| #order (q-1) and (q+1) | ||
| #we do not need memory in the group image |
Collaborator
There was a problem hiding this comment.
Why did you remove this comment?
Till-Eisen
force-pushed
the
FindSL2inSLd
branch
from
August 25, 2026 09:53
8a7f4c5 to
5aaaff8
Compare
Till-Eisen
force-pushed
the
FindSL2inSLd
branch
from
August 25, 2026 09:54
5aaaff8 to
6a25cef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title describes, I added some remarks for better understanding. I did not go into every detail though.