Skip to content

Enable TestGroupOptions.tryNonGroupElements #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SoongNoonien wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enable TestGroupOptions.tryNonGroupElements #428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71c1b6b
Enable TestGroupOptions.tryNonGroupElements
ssiccha Mar 31, 2026
cf21ddd
Guard against inputs outside the group
fingolfin May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gap/base/recognition.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1029,7 +1029,7 @@ RECOG.TestGroupOptions := rec(

# if the following is set to true, then we test what happens if SLPforElement
# is called with elements outside the group
tryNonGroupElements := false
tryNonGroupElements := true
);


Expand Down
6 changes: 6 additions & 0 deletions gap/perm/giant.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,6 +574,9 @@ RECOG.SLPforSn := function( n, pi )

local cycles, initpts, c, newc, i, R, ci, cycslp, k ;

if pi = fail then
return fail;
fi;
if IsOne(pi) then
return StraightLineProgramNC( [[1,0]], 2 );
fi;
Expand Down Expand Up @@ -644,6 +647,9 @@ RECOG.SLPforAn := function( n, pi )
local cycles, initpts, c, newc, R, i, nexttrpn, ci, cycslp, k, j,
nexttau, nextsigma ;

if pi = fail then
return fail;
fi;
if IsOne(pi) then
return StraightLineProgramNC( [[1,0]], 2 );
fi;
Expand Down
Loading