Implement #1370 (reflection matrix calculation) - #1371
Merged
Merged
Conversation
christophe-lunarg
self-requested a review
October 11, 2025 10:01
christophe-lunarg
requested changes
Oct 11, 2025
christophe-lunarg
left a comment
christophe-lunarg
left a comment
There was a problem hiding this comment.
A problem with this PR is that is removed reflect2D and also it doesn't have any test for reflect3D.
christophe-lunarg
force-pushed
the
gtx_transform2/reflect
branch
from
October 11, 2025 10:03
501fba1 to
8f504b7
Compare
- add reflect2D - rewrite functions to accept an input matrix - add tests
christophe-lunarg
approved these changes
Dec 8, 2025
|
Thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a fixed calculation for 3D reflection matrices.