-
Notifications
You must be signed in to change notification settings - Fork 7
Deprecate motile run #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Deprecate motile run #447
Changes from 7 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
28cf382
Add separate branches in save/load for Tracks and MotileRun
cmalinmayor 3e98bdd
Separate logic for export and internal save to geff
cmalinmayor 3d153ea
Add docstrings for tracks_saved and tracks_loaded signals
cmalinmayor 5281f77
Merge branch 'main' into deprecate-motile-run
cmalinmayor de7c1b2
Remove pinned funtracks dep
cmalinmayor aeb1200
Upgrade funtracks lower bound
cmalinmayor 6f97901
Merge branch 'main' into deprecate-motile-run
TeunHuijben 295b7d0
update docstrings
TeunHuijben 8d040cd
disconnect TracksViewer when the same Tracks object is viewed in mult…
TeunHuijben ef0491a
Add separate dialog for saving internal format geff
cmalinmayor 434cc0b
Emit SolutionTracks from TracksList
cmalinmayor f89619c
Ignore deprecation warnings until next major funtracks release
cmalinmayor bfa71e3
Clean up loading code
cmalinmayor bb6b4e1
Unify signal paths to always point to the .geff
cmalinmayor 5ed3e5f
Explicitly save and load the timestamps from run attrs
cmalinmayor 810bc3e
Update motile run save to not create timestamped dir
cmalinmayor 6a20327
Use widget insted of pop-up dialog for internal save location
cmalinmayor a5d5b21
Suppress warnings about extra files in zarr
cmalinmayor 40baf12
Make agnostic to zarr version
cmalinmayor dbdd5f1
Fix bug where tracklet id isn't computed before emitting
cmalinmayor 99607d7
Remove unnecessary mkdir command
cmalinmayor fa1d280
More edge case geff fixes
cmalinmayor b839498
Update docs to reflect import/export vs save/load
cmalinmayor fc677d0
Merge branch 'main' into deprecate-motile-run
cmalinmayor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure
overwrite=Trueis good here? What ifdirectoryis a normal folder, and during loading we found a geff in there. Does this mean we only overwite the geff, or the entire directory? I think we have to be very careful, since with the new loading strategy,directorycan be a lot of things (any folder containing a geff, a .zarr with a geff inside, the .geff store itself, etc.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah I actually had a local unpushed commit where I made a separate dialog for the "internal" format. But I agree that this is confusing, partially because the internal GEFF save will hopefully be replaced with the persistent sql graph soon..... 🙃 I'll clean it up a bit and clarify the two paths with docstirngs and docs