Skip to content

fix(macrobenchmarks): use random optimizer moments, not zeros, in CPU sim#949

Merged
zhixiangli merged 1 commit into
fsspec:mainfrom
zhixiangli:use-random-optimizer-moments
Jul 3, 2026
Merged

fix(macrobenchmarks): use random optimizer moments, not zeros, in CPU sim#949
zhixiangli merged 1 commit into
fsspec:mainfrom
zhixiangli:use-random-optimizer-moments

Conversation

@zhixiangli

@zhixiangli zhixiangli commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

This pull request updates the _materialize_adamw_state function in the Llama 3.1 8B CPU simulation benchmark to initialize AdamW optimizer states with random values instead of zeros, preventing trivial data compression and ensuring realistic IO benchmark results. I have no feedback to provide as there are no review comments.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the _materialize_adamw_state function in the Llama 3.1 8B CPU simulation benchmark to initialize AdamW optimizer states with random values instead of zeros, preventing trivial data compression and ensuring realistic IO benchmark results. I have no feedback to provide as there are no review comments.

@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.68%. Comparing base (1b08827) to head (e2ecb09).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #949   +/-   ##
=======================================
  Coverage   89.68%   89.68%           
=======================================
  Files          16       16           
  Lines        3579     3579           
=======================================
  Hits         3210     3210           
  Misses        369      369           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yuxin00j yuxin00j left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove the last sentence in the PR description?

@zhixiangli zhixiangli merged commit 80ea100 into fsspec:main Jul 3, 2026
10 checks passed
@zhixiangli zhixiangli deleted the use-random-optimizer-moments branch July 3, 2026 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants