Remove precommit hooks

[spacey-sooty]

Description

I removed the precommit hooks because they are annoying and keep failing for people. Just run the commands you need to.

Meta

Merge checklist:

• Pull Request title is short, imperative summary of proposed changes
• The description documents the what and why, including events that led to this PR
• Pull Request has been linted and formatted and follows the styleguide

[github-actions]

🌐 Preview URL: https://pr-249-frcsoftware.frcsoftware.workers.dev

[samfreund]

I'm against this until we demonstrate what the issues people are hitting are, and that they're unresolvable.

[TheComputer314]

Linting before committing does allow for guarantees that the commit is cleanly formatted and whatnot, but sometimes the linter is broken or you just wanna throw down a commit without linting. Commit hooks can be bypassed, but it's not an easily accessible setting in most IDEs and it auto-resets to no bypass on IntelliJ.

Lint-staged also only lints things within the git stage, which can sometimes fail if additional stuff needs to be linted, if the lint depends on something else, or if you use an IDE that doesn't use the traditional git staging mechanism such as IntelliJ.

Linting also takes a few seconds before the lint actually saves, and if it fails VSCode and IntelliJ doesn't make it obvious why it failed in the commit hook.

I'm in favor of removing pre-commit hooks, then maybe adding back in a pre-push hook when we've stabilized the linter.

[Daniel1464]

Can we make precommit hooks opt-in instead of opt-out? As in, doing git commit -f -n "my commit" will run the hooks.