fix: preserve customer manager ticket visibility for agents - #3715
Open
uttam282005 wants to merge 1 commit into
Open
fix: preserve customer manager ticket visibility for agents#3715uttam282005 wants to merge 1 commit into
uttam282005 wants to merge 1 commit into
Conversation
|
Tick the box to add this pull request to the merge queue (same as
|
Contributor
Confidence Score: 5/5The PR appears safe to merge. The added list predicate uses the same manager relationship as document permission checks without widening access beyond that existing grant. Reviews (1): Last reviewed commit: "fix: preserve customer manager ticket vi..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
has_permission().Testing
Verified the regression test fails on the original implementation and passes with the fix:
bench --site helpdesk.test run-tests --app helpdesk --module helpdesk.helpdesk.doctype.hd_ticket.test_hd_ticket --test test_customer_managers_see_their_tickets_in_lists