Skip to content

fix: preserve customer manager ticket visibility for agents - #3715

Open
uttam282005 wants to merge 1 commit into
frappe:developfrom
uttam282005:fix/hd-ticket-customer-manager-visibility
Open

fix: preserve customer manager ticket visibility for agents#3715
uttam282005 wants to merge 1 commit into
frappe:developfrom
uttam282005:fix/hd-ticket-customer-manager-visibility

Conversation

@uttam282005

Copy link
Copy Markdown

Summary

  • Restore managed-customer visibility for agents in ticket list queries.
  • Keep list-level visibility consistent with has_permission().
  • Add a regression test for agents who manage customers whose tickets belong to another team.

Testing

Verified the regression test fails on the original implementation and passes with the fix:

bench --site helpdesk.test run-tests --app helpdesk --module helpdesk.helpdesk.doctype.hd_ticket.test_hd_ticket --test test_customer_managers_see_their_tickets_in_lists

@mergify

mergify Bot commented Aug 23, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@greptile-apps

greptile-apps Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

The PR appears safe to merge.

The added list predicate uses the same manager relationship as document permission checks without widening access beyond that existing grant.

Reviews (1): Last reviewed commit: "fix: preserve customer manager ticket vi..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant