fix(sla): freeze resolution overdue timer while ticket is paused - #3709
fix(sla): freeze resolution overdue timer while ticket is paused#3709RitvikSardana wants to merge 1 commit into
Conversation
|
Tick the box to add this pull request to the merge queue (same as
|
Confidence Score: 4/5The PR appears safe to merge, with regression coverage for the paused-overdue display recommended. The changed duration and popover paths are coherent, but their time-dependent behavior is currently untested. Files Needing Attention: desk/src/composables/useSLA.ts; desk/src/components/ticket-agent/TicketSLA.vue Prompt To Fix All With AI### Issue 1
desk/src/composables/useSLA.ts:178-182
**Cover the paused-overdue regression**
Add a regression test for a resolution SLA breached before pausing, covering both the frozen overdue duration and the associated hold timestamp; without it, future changes can silently restore the growing timer or drop its context.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "fix(sla): freeze resolution overdue time..." | Re-trigger Greptile |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3709 +/- ##
========================================
Coverage 73.76% 73.76%
========================================
Files 148 148
Lines 10841 10841
========================================
Hits 7997 7997
Misses 2844 2844 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
A ticket paused after its resolution deadline showed an "Overdue by" number that kept climbing while the SLA clock was stopped, with nothing on the card or popover saying the ticket was on hold.
on_hold_sincewhen the ticket is paused, so it reports the breach that happened before the pause instead of counting hold time as lateness.overduemetrics, not justhold.The card keeps reading "Overdue" rather than "On Hold" here: the SLA already failed before the pause (
agreement_status: "Failed"), and a blue "On Hold" would hide that.