fix: localize ticket detail UI - #3707
Conversation
Confidence Score: 4/5The PR is not yet safe to merge because localized mobile view events remain incorrectly grouped. The desktop comparison is fixed, but MobileTicketAgent still constructs translated “viewed this” content and compares it against the English literal. Files Needing Attention: desk/src/components/ticket-agent/TicketActivityPanel.vue and desk/src/pages/ticket/MobileTicketAgent.vue Prompt To Fix All With AI### Issue 1
desk/src/components/ticket-agent/TicketActivityPanel.vue:218
**Mobile activity grouping stays untranslated**
When a mobile user views consecutive ticket-view events in a locale translating `viewed this`, the mobile activity path constructs translated content but compares it with the English literal, causing those events to be folded into a “+N changes” group.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (2): Last reviewed commit: "fix: preserve localized activity groupin..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
Tick the box to add this pull request to the merge queue (same as
|
| nextActivity && | ||
| nextActivity.user === currentActivity.user && | ||
| nextActivity.content !== "viewed this" && | ||
| nextActivity.content !== __("viewed this") && |
There was a problem hiding this comment.
When a mobile user views consecutive ticket-view events in a locale translating viewed this, the mobile activity path constructs translated content but compares it with the English literal, causing those events to be folded into a “+N changes” group.
Knowledge Base Used: Desk Ticket UI
Prompt To Fix With AI
This is a comment left during a code review.
Path: desk/src/components/ticket-agent/TicketActivityPanel.vue
Line: 218
Comment:
**Mobile activity grouping stays untranslated**
When a mobile user views consecutive ticket-view events in a locale translating `viewed this`, the mobile activity path constructs translated content but compares it with the English literal, causing those events to be folded into a “+N changes” group.
**Knowledge Base Used:** [Desk Ticket UI](https://app.greptile.com/frappe/-/custom-context/knowledge-base/frappe/helpdesk/-/docs/desk-ticket-ui.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.2 participants
Summary
Route additional ticket-detail UI strings through the existing translation
helper so localized Helpdesk installations do not fall back to English for
common agent-facing actions and SLA details.
Changes
viewed thisOverdue by ${...}text with a placeholder-basedtranslation string
Why
Several common ticket-detail strings were still hardcoded in English even when
translations existed in the locale catalogue. This caused mixed-language UI on
localized installations.
Testing
Tested on:
nl)Verified that the affected labels render through the translation catalogue and
that the production frontend build succeeds.