feat: floating composer - #3674
Draft
aerodeval wants to merge 4 commits into
Draft
Conversation
The header already started a resize anywhere that wasn't a button, but the tab switcher and window controls cover both top corners, so grabbing one did nothing. The empty pill also read "Add a comment" while clicking it opens the email reply.
…mposer # Conflicts: # desk/src/components/CommunicationArea.vue # desk/src/components/EmailEditor.vue
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3674 +/- ##
===========================================
+ Coverage 73.76% 73.80% +0.03%
===========================================
Files 148 148
Lines 10841 10845 +4
===========================================
+ Hits 7997 8004 +7
+ Misses 2844 2841 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the ticket page's
EmailEditor/CommentTextEditorwith the@framework/uiEmailComposer/CommentComposerhosted in afrappe-ui/experimentalFloatingWindow. One rewritten file, both old editors deleted, net −522 lines.Depends on frappe/frappe#40280 (
@framework/uicomposers). Draft until that lands.What changes
Email/Commentare tabs inside the window header instead of two separate editors.localStoragedraft keys all behave as before.Before / after
Email/Commenttabs in its headerScreenshots
Notes
EmailComposerheader rows now share a grid so the label column is only as wide as the widest label rendered — previously a hardcoded52pxsized for a "Subject" row helpdesk never shows, which left a visible gap between "To" and its recipients. That part lives in the frappe PR.Demo:
Screen.Recording.2026-08-05.at.4.03.23.AM.mov