Skip to content

Fix header and footer in rtl body direction #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ahmed-madi wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix header and footer in rtl body direction #56

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fefe841
fix header and footer scrolling in rtl direction
Jan 20, 2019
2b7ae2d
Delete package-lock.json
ahmed-madi Jan 20, 2019
4537458
Merge branch 'master' into master
ahmed-madi Oct 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@
"dependencies": {
"hyperlist": "^1.0.0-beta",
"lodash": "^4.17.5",
"normalize-scroll-left": "^0.1.2",
"sortablejs": "^1.7.0"
},
"config": {
Expand Down
26 changes: 20 additions & 6 deletions src/style.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import {
linkProperties,
throttle
} from './utils';
import { detectScrollType } from 'normalize-scroll-left';

export default class Style {
constructor(instance) {
Expand Down Expand Up @@ -49,12 +50,25 @@ export default class Style {

requestAnimationFrame(() => {
const scrollLeft = e.target.scrollLeft;
$.style(this.header, {
transform: `translateX(-${scrollLeft}px)`
});
$.style(this.footer, {
transform: `translateX(-${scrollLeft}px)`
});
const direction = getComputedStyle(document.getElementsByTagName('body')[0]).direction;
if (direction === 'rtl' && detectScrollType() === 'default') {
const scrollWidth = e.target.scrollWidth;
const clientWidth = e.target.clientWidth;
$.style(this.header, {
transform: `translateX(${scrollWidth - clientWidth - scrollLeft}px)`
});
$.style(this.footer, {
transform: `translateX(${scrollWidth - clientWidth - scrollLeft}px)`
});
}
else {
$.style(this.header, {
transform: `translateX(${-scrollLeft}px)`
});
$.style(this.footer, {
transform: `translateX(${-scrollLeft}px)`
});
}
this._settingHeaderPosition = false;
});
});
Expand Down