Simplify GenericTarSubLoader#1880
Open
JSCU-CNI wants to merge 2 commits into
Open
Conversation
Schamper
requested changes
Jul 9, 2026
Comment on lines
-125
to
-133
| for vol_name, vol in volumes.items(): | ||
| loaderutil.add_virtual_ntfs_filesystem( | ||
| target, | ||
| vol, | ||
| usnjrnl_path=[ | ||
| "$Extend/$Usnjrnl:$J", | ||
| "$Extend/$Usnjrnl:J", # Old versions of acquire used $Usnjrnl:J | ||
| ], | ||
| ) |
Member
There was a problem hiding this comment.
Is this functionality not lost? Or is this just old legacy acquire stuff that we can probably safely remove now?
Maybe strange that I'm the one asking this question 😄 but I'm hoping you can refresh my memory on this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves all parsing logic in the GenericTarSubLoader to the TarFilesystem implementation. Fixes #1876.