Refactor zip filesystem#1777
Open
Schamper wants to merge 3 commits into
Open
Conversation
Merging this PR will degrade performance by 11.54%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1777 +/- ##
==========================================
+ Coverage 81.20% 81.30% +0.10%
==========================================
Files 405 405
Lines 35879 35900 +21
==========================================
+ Hits 29134 29190 +56
+ Misses 6745 6710 -35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow up to #1772, this PR aims to simplify and speed up the zip filesystem implementation a bit by getting rid of the dependency of the virtual filesystem, as well as hopefully dealing with some more edge cases.
I took some inspiration from how
zipfile.ZipPathworks for this.Correctly dealing with all the paths and variations is a bit tricky, so I'm sure there's room for improvement. This is also a bit of a test run before I commit to the tar variant, since that has a lot of loaders that depend on the implementation details of the current tar filesystem.
Fingers crossed that Codspeed agrees this is faster.