Add Android Binary XML (ABX) parser#1761
Open
JSCU-CNI wants to merge 3 commits into
Open
Conversation
* Add abx command to target-shell * Improve hostname parsing * Implement users method
JSCU-CNI
force-pushed
the
android-improvements
branch
from
May 20, 2026 09:07
4b3fa2e to
b516429
Compare
Schamper
requested changes
Jul 7, 2026
Schamper
requested changes
Jul 7, 2026
| raise ValueError(f"Unsupported DataType {data_type!r}") | ||
|
|
||
| value = reader() | ||
| elements[-1].attrib[name] = str(value) if to_str else value |
Member
There was a problem hiding this comment.
The to_str feels like it's a post processing step intertwined with a parsing step. Is there no alternative way to achieve the same?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an ABX (Android Binary XML) parser. The
AndroidPluginis extended to use ABX features (hostnameandusers).target-shellgained theabxcommand to read ABX files on the fly.