Skip to content

Pass kb args correctly to binary analysis - #192

Merged
bjk7119 merged 1 commit into
mainfrom
binary
Aug 3, 2026
Merged

Pass kb args correctly to binary analysis#192
bjk7119 merged 1 commit into
mainfrom
binary

Conversation

@bjk7119

@bjk7119 bjk7119 commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Improved binary analysis configuration by using the knowledge-base connection settings, helping analyses connect to the correct service.

@bjk7119
bjk7119 requested review from dd-jy and soimkim August 3, 2026 08:17
@bjk7119 bjk7119 self-assigned this Aug 3, 2026
@bjk7119 bjk7119 added the bug fix [PR] Fix the bug label Aug 3, 2026
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@bjk7119, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 51 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 7e8c1c10-0f4c-489a-a9ac-eb1711e972de

📥 Commits

Reviewing files that changed from the base of the PR and between 87343b1 and eaed739.

📒 Files selected for processing (2)
  • pyproject.toml
  • src/fosslight_scanner/fosslight_scanner.py
📝 Walkthrough

Walkthrough

Binary analysis now receives the knowledge-base URL and token instead of the database URL.

Changes

Binary analysis configuration

Layer / File(s) Summary
Pass knowledge-base parameters
src/fosslight_scanner/fosslight_scanner.py
The binary analysis call passes kb_url and kb_token to binary_analysis.find_binaries.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: dd-jy, soimkim

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the change to pass knowledge-base arguments to binary analysis.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch binary

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/fosslight_scanner/fosslight_scanner.py`:
- Line 281: Update the fosslight_binary dependency constraint and the call
around find_binaries so the minimum supported version includes kb_url and
kb_token; alternatively, pass kb_url, kb_token, and subsequent flags by keyword
to avoid positional binding and duplicate path_to_exclude. Preserve the existing
binary analysis behavior and upper version bound.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 4bfbdf50-0206-4e3e-805c-ec78f2a44b87

📥 Commits

Reviewing files that changed from the base of the PR and between fea1a98 and 87343b1.

📒 Files selected for processing (1)
  • src/fosslight_scanner/fosslight_scanner.py

Comment thread src/fosslight_scanner/fosslight_scanner.py
@bjk7119
bjk7119 merged commit 5f2310d into main Aug 3, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix [PR] Fix the bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant