You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Support multiple values for request headers
Current gotlsproxy code flattens req.Header into map[string]string for cycletls.Options.Headers.
That drops all but the first value for headers with multiple values.
Preserve request header name casing
CycleTLS internally uses Header.Set(k, v), which canonicalizes header names.
Some servers are sensitive to header casing even though HTTP says they should not be.
Open CycleTLS v3 beta PR: Beta 3.0.0 release Danny-Dasilva/CycleTLS#415
Mentions headers can have multiple values, but appears focused on response headers, not request header input or casing preservation.
Conclusion:
A gotlsproxy-only fix can join repeated request header values, but cannot fully preserve header casing because CycleTLS canonicalizes internally. Cleanest full fix is in CycleTLS: add support for multi-value request headers and assign directly into fhttp.Header instead of using Header.Set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR-as-issue because Issues are disabled on this fork.
Reference implementation PR:
#1
TODO:
The placeholder file exists only to keep this tracking PR open.