Adding fieldline tracing to the magnetosphere_3d_small test - #1307
Open
lassejsc wants to merge 3 commits into
Open
Adding fieldline tracing to the magnetosphere_3d_small test#1307lassejsc wants to merge 3 commits into
lassejsc wants to merge 3 commits into
Conversation
lassejsc
marked this pull request as ready for review
June 23, 2026 10:45
ykempf
approved these changes
Jun 23, 2026
ykempf
left a comment
ykempf
left a comment
Contributor
There was a problem hiding this comment.
Looks sensible I guess. And I assume you'll take my 2 cents as gold so I'll tag this as "approve". ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does what it says on the tin, I think this could be good addition since I realized the testpackage doesn't test that. The fieldline tracing params are from the FHA run (comment if something is wonky with the params)