Repository navigation
Conversation
chuxubank
force-pushed
the
feat/usb-streams
branch
2 times, most recently
from
September 22, 2026 09:43
3098094 to
f4327bc
Compare
Contributor
Author
|
Moved device reopen/retry out of this branch onto a separate PR. This branch is back to the USB and HID transports, the ARM image dependencies, and the poller drain. |
Contributor
Author
|
Moved the USB read contract into this pull request: a timeout is an empty read, any other USB error is raised, and the default read timeout is 1000 ms. Device reopen stays in #446. |
BenjiU
approved these changes
Sep 25, 2026
BenjiU
left a comment
BenjiU
left a comment
Collaborator
There was a problem hiding this comment.
looks good.
Thanks for your contribution
Release the configured USB interface during cleanup and cover the behavior with a focused CI regression test.
CI failed on linux/arm/v7 because hidapi has no wheel and its setup looks up libusb via pkg-config, which was missing from the runtime image.
A read that returns data is followed immediately by another read, so a frame already split across two device buffers is not held for read_interval.
One millisecond is shorter than a USB transfer, so the default timeout made an idle scanner look like it had no data. Keep a timeout as an empty read, and raise any other USB error.
CI rejected the untyped return on _patched.
chuxubank
force-pushed
the
feat/usb-streams
branch
from
October 12, 2026 09:05
fca9491 to
3de5435
Compare
Contributor
Author
|
Rebased onto the latest develop (59da598).
Conflict resolution keeps both behaviors: a failed read still reopens the stream, and a read that returns data is still published immediately instead of waiting another read_interval. Also annotated _patched so the strict mypy check that failed on the previous head can pass. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The branch was rebuilt on the latest
upstream/develop; device-specific demo scripts and unrelated fork CI changes were intentionally excluded.Verification
pytest mqtt_io/tests/test_stream_usb.py: 1 passedpylint -d fixme mqtt_io: 10.00/10mypy mqtt_io: 67 source files, no issuesuv build: sdist and wheel built successfullyRuntime note
A physical USB/HID device was not available for hardware validation. Dockerfile checking was attempted, but the local Docker daemon was not running.