[Linter]: Support for deprecated arguments#2630
Draft
gigalasr wants to merge 9 commits into
Draft
Conversation
gigalasr
commented
Jul 9, 2026
Collaborator
Author
|
Questions:
|
Member
Just for the argument please
unsure what you mean here because the argument names cannot be namespaced? Could you please elaborate with an example? |
Collaborator
Author
|
Member
|
Aah okay so you can use either |
Collaborator
Author
|
Sounds like it, I will try that! Thank you! |
EagleoutIce
reviewed
Jul 14, 2026
|
|
||
| export interface DeprecatedFunctionsConfig extends MergeableRecord{ | ||
| /** Functions to mark as deprecated */ | ||
| fns: (string | DeprecatedFunctionInformation)[] |
| } | ||
|
|
||
| export interface DeprecatedFunctionResultBase extends LintingResult { | ||
| function: BrandedIdentifier |
Member
There was a problem hiding this comment.
Why just branded? please use the full Identifier here
| return undefined; | ||
| } | ||
|
|
||
| const arg = vertex.args.find((arg, idx) => |
Member
There was a problem hiding this comment.
we have argument finders like pMatch for this, please use them :D
There is also getValueOfArgument`
| certainty: LintingResultCertainty.Certain, | ||
| involvedId: argNode.info.id, | ||
| function: e.target, | ||
| arg: (deprecatedArgInfo.argName ?? deprecatedArgInfo.argIdx) as string | number, |
| } | ||
| str.push(`Function \`${result.function}\` is ${result.state ?? 'deprecated'}`); | ||
| if(result.sinceVersion) { | ||
| str.push(`since version ${result.sinceVersion.format()}`); |
Member
There was a problem hiding this comment.
shouldn't we check whether the since Version range contract is even fulfilled?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1870
TODO: