Speed up nmod_poly_evaluate_nmod asymptotically#2752
Merged
Conversation
Collaborator
|
Looks very nice!
Special cases like evaluation at |
Collaborator
Author
|
Some ideas to improve the rectangular algorithm, if you're interested:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rectangular splitting makes
nmod_poly_evaluate_nmodas fast as dot products asymptotically. On Zen 3 this is 14x faster for small moduli, 3x faster for 62/63-bit moduli, and 7x faster for 64-bit moduli.Also, algorithm selection is moved to the underscore method.
The crossover at length 50 could be fine-tuned.
This is might obsolete some of the optimizations proposed in #2492 (others may be complementary).