Fix time.Ticker leak in conditional access polling#48538
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #48538 +/- ##
==========================================
+ Coverage 67.90% 68.00% +0.09%
==========================================
Files 3678 3678
Lines 233673 233679 +6
Branches 12452 12452
==========================================
+ Hits 158686 158903 +217
+ Misses 60724 60473 -251
- Partials 14263 14303 +40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Related issue: Closes #42901
Checklist for submitter
Changes file added for user-visible changes in
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
Input data is properly validated,
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters.Timeouts are implemented and retries are limited to avoid infinite loops
Summary
time.Tickwithtime.NewTicker+defer ticker.Stop()in the conditional access polling loop inserver/service/osquery.goTesting
go vet ./server/service/...-- passed with no issuesgo test -run "ConditionalAccess" ./server/service/ -count=1) -- all passedTestConditionalAccess*inintegration_enterprise_test.go) requireMYSQL_TEST=1 REDIS_TEST=1and will be validated in CI🤖 Generated with Claude Code