Bring in additions to api_endpoints.yml#48532
Open
rachaelshaw wants to merge 1 commit into
Open
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
fleet-release
approved these changes
Jun 30, 2026
2 tasks
Member
Author
|
FYI @noahtalerman it looks like some of the SCIM endpoints are causing the tests to fail; do all of them need to be available to API-only users, or can we comment them out for now? |
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rc-patch-fleet-v4.88.0 #48532 +/- ##
=========================================================
Coverage ? 54.43%
=========================================================
Files ? 1672
Lines ? 192377
Branches ? 0
=========================================================
Hits ? 104722
Misses ? 76135
Partials ? 11520
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cdcme
approved these changes
Jul 1, 2026
rachaelshaw
commented
Jul 1, 2026
Comment on lines
+668
to
+711
| path: "/api/v1/fleet/scim/Users" | ||
| display_name: "List SCIM users" | ||
| - method: "POST" | ||
| path: "/api/v1/fleet/scim/Users" | ||
| display_name: "Create SCIM user" | ||
| - method: "GET" | ||
| path: "/api/v1/fleet/scim/Users/:id" | ||
| display_name: "Get SCIM user" | ||
| - method: "PUT" | ||
| path: "/api/v1/fleet/scim/Users/:id" | ||
| display_name: "Replace SCIM user" | ||
| - method: "PATCH" | ||
| path: "/api/v1/fleet/scim/Users/:id" | ||
| display_name: "Update SCIM user" | ||
| - method: "DELETE" | ||
| path: "/api/v1/fleet/scim/Users/:id" | ||
| display_name: "Delete SCIM user" | ||
| - method: "GET" | ||
| path: "/api/v1/fleet/scim/Groups" | ||
| display_name: "List SCIM groups" | ||
| - method: "POST" | ||
| path: "/api/v1/fleet/scim/Groups" | ||
| display_name: "Create SCIM group" | ||
| - method: "GET" | ||
| path: "/api/v1/fleet/scim/Groups/:id" | ||
| display_name: "Get SCIM group" | ||
| - method: "PUT" | ||
| path: "/api/v1/fleet/scim/Groups/:id" | ||
| display_name: "Replace SCIM group" | ||
| - method: "PATCH" | ||
| path: "/api/v1/fleet/scim/Groups/:id" | ||
| display_name: "Update SCIM group" | ||
| - method: "DELETE" | ||
| path: "/api/v1/fleet/scim/Groups/:id" | ||
| display_name: "Delete SCIM group" | ||
| - method: "GET" | ||
| path: "/api/v1/fleet/scim/Schemas" | ||
| display_name: "Get SCIM schemas" | ||
| - method: "GET" | ||
| path: "/api/v1/fleet/scim/ServiceProviderConfig" | ||
| display_name: "Get SCIM service provider config" | ||
| - method: "GET" | ||
| path: "/api/v1/fleet/scim/ResourceTypes" | ||
| display_name: "Get SCIM resource types" |
Member
Author
There was a problem hiding this comment.
@lucasmrod do you know if these SCIM endpoints are documented incorrectly? They're causing tests to fail with error initializing API endpoints: the following API endpoints are unknown: …
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This file is what populates the API endpoints available to limit API-only users' access.
The changes here include some endpoints whose experimental status was recently removed, and the missing SCIM endpoints. We want to make these available for API-only users as soon as possible.