Skip to content

Rename product groups: #g-mdm → #g-apple-at-work, #g-software → #g-auto-patching#48482

Merged
georgekarrv merged 2 commits into
mainfrom
georgekarrv/rename-product-groups
Jul 1, 2026
Merged

Rename product groups: #g-mdm → #g-apple-at-work, #g-software → #g-auto-patching#48482
georgekarrv merged 2 commits into
mainfrom
georgekarrv/rename-product-groups

Conversation

@georgekarrv

@georgekarrv georgekarrv commented Jun 30, 2026

Copy link
Copy Markdown
Member

Related issue: Resolves #

Description

Renames two product groups in the handbook:

  • #g-mdm#g-apple-at-work
  • #g-software#g-auto-patching

Updates all references across the handbook, including the visible channel/label names and the embedded GitHub label-search URLs.

Files changed:

  • handbook/company/product-groups.md
  • handbook/product-design/README.md
  • handbook/engineering/README.md
  • handbook/engineering/engineering.rituals.yml
  • handbook/customer-success/README.md

Checklist for submitter

  • QA'd all new/changed functionality manually (docs-only change; verified all references updated and no stale g-mdm/g-software mentions remain)

Summary by CodeRabbit

  • Documentation
    • Updated the Release QA guidance to reflect the current sprint boards used for moving issues into ✅ Ready for release.
    • Replaced the outdated board reference with the latest board names.

Copilot AI review requested due to automatic review settings June 30, 2026 13:50

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

In handbook/engineering/engineering.rituals.yml, the "Release QA" ritual description is updated to reference the #g-apple-at-work sprint board instead of #g-mdm, while retaining the #g-endpoint-ops board and the "✅ Ready for release" column target.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the handbook product-group rename, but it is broader than the single documented board-reference update.
Description check ✅ Passed The description covers the change, affected files, and checklist, but the related issue placeholder is still blank.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch georgekarrv/rename-product-groups

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@handbook/engineering/engineering.rituals.yml`:
- Line 112: The Release QA rename is only partial because the handbook now says
`#g-apple-at-work` while the release automation and GitHub label canonicalization
still use `#g-mdm`. Update the related tooling in publish_release.sh and the ghapi
views code plus its tests so they all reference the same board/label as the
handbook, or revert this handbook rename until the automation migration is
completed. Use the existing symbols publish_release.sh, views.go, and
views_test.go to locate the affected logic and keep the naming consistent across
the workflow.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 962b7970-2653-4eaa-b01b-975ce13258e1

📥 Commits

Reviewing files that changed from the base of the PR and between bf352c7 and a95433e.

⛔ Files ignored due to path filters (4)
  • handbook/company/product-groups.md is excluded by !**/*.md
  • handbook/customer-success/README.md is excluded by !**/*.md
  • handbook/engineering/README.md is excluded by !**/*.md
  • handbook/product-design/README.md is excluded by !**/*.md
📒 Files selected for processing (1)
  • handbook/engineering/engineering.rituals.yml

startedOn: "2023-08-09"
frequency: "Triweekly"
description: "Every release cycle, by end of day Friday of release week, move all issues to the ”✅ Ready for release” column on the #g-mdm and #g-endpoint-ops sprint boards."
description: "Every release cycle, by end of day Friday of release week, move all issues to the ”✅ Ready for release” column on the #g-apple-at-work and #g-endpoint-ops sprint boards."

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy lift

This rename is incomplete for the Release QA workflow.

Line 112 now tells people to use #g-apple-at-work, but the supplied release tooling still hard-codes #g-mdm for QA issue creation in tools/release/publish_release.sh:383-394, and tools/github-manage/pkg/ghapi/views.go:11-16 plus tools/github-manage/pkg/ghapi/views_test.go:23-28 still treat #g-mdm as the canonical label. That leaves the handbook and automation pointing at different boards/labels for the same process. Please update those consumers in the same rollout, or keep the old name here until the tooling migration lands.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@handbook/engineering/engineering.rituals.yml` at line 112, The Release QA
rename is only partial because the handbook now says `#g-apple-at-work` while the
release automation and GitHub label canonicalization still use `#g-mdm`. Update
the related tooling in publish_release.sh and the ghapi views code plus its
tests so they all reference the same board/label as the handbook, or revert this
handbook rename until the automation migration is completed. Use the existing
symbols publish_release.sh, views.go, and views_test.go to locate the affected
logic and keep the naming consistent across the workflow.

noahtalerman
noahtalerman previously approved these changes Jul 1, 2026

@noahtalerman noahtalerman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Product Design page looks good 👍

Comment thread handbook/customer-success/README.md Outdated
@georgekarrv georgekarrv merged commit bfc78dc into main Jul 1, 2026
10 checks passed
@georgekarrv georgekarrv deleted the georgekarrv/rename-product-groups branch July 1, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants