Rename product groups: #g-mdm → #g-apple-at-work, #g-software → #g-auto-patching#48482
Conversation
…g-auto-patching in handbook
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
WalkthroughIn 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@handbook/engineering/engineering.rituals.yml`:
- Line 112: The Release QA rename is only partial because the handbook now says
`#g-apple-at-work` while the release automation and GitHub label canonicalization
still use `#g-mdm`. Update the related tooling in publish_release.sh and the ghapi
views code plus its tests so they all reference the same board/label as the
handbook, or revert this handbook rename until the automation migration is
completed. Use the existing symbols publish_release.sh, views.go, and
views_test.go to locate the affected logic and keep the naming consistent across
the workflow.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 962b7970-2653-4eaa-b01b-975ce13258e1
⛔ Files ignored due to path filters (4)
handbook/company/product-groups.mdis excluded by!**/*.mdhandbook/customer-success/README.mdis excluded by!**/*.mdhandbook/engineering/README.mdis excluded by!**/*.mdhandbook/product-design/README.mdis excluded by!**/*.md
📒 Files selected for processing (1)
handbook/engineering/engineering.rituals.yml
| startedOn: "2023-08-09" | ||
| frequency: "Triweekly" | ||
| description: "Every release cycle, by end of day Friday of release week, move all issues to the ”✅ Ready for release” column on the #g-mdm and #g-endpoint-ops sprint boards." | ||
| description: "Every release cycle, by end of day Friday of release week, move all issues to the ”✅ Ready for release” column on the #g-apple-at-work and #g-endpoint-ops sprint boards." |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy lift
This rename is incomplete for the Release QA workflow.
Line 112 now tells people to use #g-apple-at-work, but the supplied release tooling still hard-codes #g-mdm for QA issue creation in tools/release/publish_release.sh:383-394, and tools/github-manage/pkg/ghapi/views.go:11-16 plus tools/github-manage/pkg/ghapi/views_test.go:23-28 still treat #g-mdm as the canonical label. That leaves the handbook and automation pointing at different boards/labels for the same process. Please update those consumers in the same rollout, or keep the old name here until the tooling migration lands.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@handbook/engineering/engineering.rituals.yml` at line 112, The Release QA
rename is only partial because the handbook now says `#g-apple-at-work` while the
release automation and GitHub label canonicalization still use `#g-mdm`. Update
the related tooling in publish_release.sh and the ghapi views code plus its
tests so they all reference the same board/label as the handbook, or revert this
handbook rename until the automation migration is completed. Use the existing
symbols publish_release.sh, views.go, and views_test.go to locate the affected
logic and keep the naming consistent across the workflow.
noahtalerman
left a comment
There was a problem hiding this comment.
Product Design page looks good 👍
Related issue: Resolves #
Description
Renames two product groups in the handbook:
#g-mdm→#g-apple-at-work#g-software→#g-auto-patchingUpdates all references across the handbook, including the visible channel/label names and the embedded GitHub label-search URLs.
Files changed:
handbook/company/product-groups.mdhandbook/product-design/README.mdhandbook/engineering/README.mdhandbook/engineering/engineering.rituals.ymlhandbook/customer-success/README.mdChecklist for submitter
g-mdm/g-softwarementions remain)Summary by CodeRabbit