Skip to content

Remove starter-library/#48478

Open
noahtalerman wants to merge 1 commit into
mainfrom
noahtalerman-patch-65
Open

Remove starter-library/#48478
noahtalerman wants to merge 1 commit into
mainfrom
noahtalerman-patch-65

Conversation

@noahtalerman

@noahtalerman noahtalerman commented Jun 30, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Cleaned up the starter library configuration by removing two preconfigured team entries from the example setup.

- @noahtalerman: New Fleet instances now use the `fleetctl new` templates: https://github.com/fleetdm/fleet/pull/42768/changes
- This starter library was only used for new Fleet instances and as of the changes above is no longer used

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@noahtalerman

Copy link
Copy Markdown
Member Author

Hey @lukeheath when you get the chance can you please sanity check me on the above? The starter-library.yml is no longer used.

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 759bf14b-742c-4224-9997-41becda61977

📥 Commits

Reviewing files that changed from the base of the PR and between bf352c7 and 8b03b3b.

📒 Files selected for processing (1)
  • docs/01-Using-Fleet/starter-library/starter-library.yml
💤 Files with no reviewable changes (1)
  • docs/01-Using-Fleet/starter-library/starter-library.yml

Walkthrough

The docs/01-Using-Fleet/starter-library/starter-library.yml file has two team manifest entries removed: the "💻 Workstations" and "📱🔐 Personal mobile devices" team definitions (each with apiVersion: v1, kind: team, and a spec.team.name field). No other files are modified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description states the intent but misses the required template sections, issue reference, testing, and checklist details. Rewrite it to follow the template: add the related issue, complete applicable checklist items, and include testing notes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: removing the starter-library directory.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch noahtalerman-patch-65

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants