Modernise friendo - #277
Merged
Merged
Conversation
jb3
approved these changes
Feb 17, 2026
jb3
approved these changes
Feb 17, 2026
ChrisLovering
force-pushed
the
modernise-friendo
branch
from
February 17, 2026 22:46
a570e25 to
e892024
Compare
jb3
approved these changes
Feb 17, 2026
This is acutally only used in the version command
jb3
approved these changes
Feb 17, 2026
This also raises errors when friendo API errors
jb3
approved these changes
Feb 17, 2026
fisher60
requested changes
Feb 17, 2026
fisher60
left a comment
fisher60
left a comment
Owner
There was a problem hiding this comment.
Small nitpicks, the only semi-important one is preserving the logging for disabling cogs since it can lead to confusion when running the app.
fisher60
reviewed
Feb 17, 2026
| ctx: Context, task_type: str = "todo_list", *, todos: tuple[str] | None = None | ||
| ) -> None: | ||
| """Wrapper function for todo list to allow the todos to be created on function call.""" | ||
| pass |
Owner
There was a problem hiding this comment.
This is weird, no clue why this was here, guess we will find out >:)
fisher60
reviewed
Feb 17, 2026
| todo_file_read[str(ctx.author.id)] = { | ||
| num: todo.strip().rstrip() | ||
| for num, todo in enumerate(todos, start=1) | ||
| num: todo.strip().rstrip() for num, todo in enumerate(todos, start=1) |
fisher60
requested changes
Feb 17, 2026
jb3
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.