Skip to content

fix(search): stop collecting task context in CLI search - #315

Merged
KrisOei merged 2 commits into
mainfrom
kris/remove-cli-search-objective
Oct 13, 2026
Merged

KrisOei merged 2 commits into
mainfrom
kris/remove-cli-search-objective

Conversation

@KrisOei

@KrisOei KrisOei commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Hide Search's --objective and --client-model flags and stop forwarding their values to the API. Continue accepting both legacy flags so existing scripts keep working. Remove both fields from the Search options type; feedback objectives and non-search model fields are unchanged.

Validation: build, typecheck, formatting, and 123 targeted search/feedback checks passed. A built-CLI process check against a local HTTP fixture confirmed calls with neither, either, and both legacy flags succeed, search help and outbound bodies omit both fields, and feedback help retains its objective. Live hosted-backend validation remains pending.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Shadow auto-approve: would auto-approve. Stops forwarding the CLI search --objective flag to the API while still accepting it for legacy scripts, and removes it from SearchOptions. Bounded compatibility-preserving fix with tests verifying objective is omitted and clientModel is preserved.

View guided diff | Turn on auto-fix | Re-trigger cubic

@capy-ai capy-ai Bot changed the title fix(search): stop collecting objective in CLI search fix(search): stop collecting task context in CLI search Oct 13, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 4 files (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Shadow auto-approve: would require human review. Stops CLI search from forwarding --objective and --client-model, hides both flags while still accepting them, and removes the fields from SearchOptions. This extends the prior approval by also dropping clientModel; live hosted-backend validation is still pending.

View guided diff | Turn on auto-fix | Re-trigger cubic

@KrisOei
KrisOei merged commit b38057a into main Oct 13, 2026
8 checks passed
@KrisOei
KrisOei deleted the kris/remove-cli-search-objective branch October 13, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant