Repository navigation
Reuse firecrawl-cli login: credentials.json fallback for API key - #3
Merged
Merged
Conversation
resolveCredentials() now resolves in order: FIRECRAWL_API_KEY/URL env -> firecrawl-cli credentials.json (the key `firecrawl login` stores, per-OS path mirrored from cli/src/utils/credentials.ts) -> clear error. One key serves both browser.provider and command.run. Env always wins. Tests: +2 hermetic cases (file fallback, env-overrides-file) using isolated temp HOMEs so the suite never reads the real machine's credentials. 12 total. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets a user who ran
firecrawl loginuse the plugin with no env var — the plugin reads the API key the CLI stored.Resolution order (env always wins)
FIRECRAWL_API_KEY(+FIRECRAWL_API_URL) envfirecrawl-clicredentials.json— per-OS path mirrored fromcli/src/utils/credentials.ts(macOS~/Library/Application Support/firecrawl-cli, Linux~/.config/firecrawl-cli, Windows%AppData%/firecrawl-cli)FIRECRAWL_API_KEYor runfirecrawl loginThe CLI's browser login resolves to a real
fc-API key and saves{ apiKey, apiUrl }, so the same key works for bothbrowser.providerandcommand.run.Why reading the file is safe here
It's a stable, documented shape (
StoredCredentials = { apiKey?, apiUrl? }), deterministic per-OS path,chmod 0600. Treated as a best-effort fallback: missing/corrupt → falls through to the env-var contract. Never logged.Verification
node --test12/12 (incl. file-fallback + env-overrides-file, isolated temp HOMEs).🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Documentation