tutorial: Changed getObject to lookupObject - #406
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @DracoBlue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses an inaccuracy in the microblog tutorial by updating an incorrect method call and ensuring necessary data is available for the corrected method. The change ensures the tutorial remains functional and provides accurate guidance to users.
Highlights
- Tutorial Correction: The tutorial has been updated to use the correct
lookupObjectmethod instead of the non-existentgetObjectmethod. - Data Population for Lookup: The
post.urlandpost.uriproperties are now properly populated before callinglookupObject, as the method relies onpost.urifor object lookup. - Documentation Alignment: The explanatory text within the tutorial has been updated to reflect the change from
getObject()tolookupObject().
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the tutorial to use lookupObject instead of getObject, which is a good correction. The changes also properly populate the post object with url and uri properties before it's used. However, this introduces an issue where a variable noteArgs is removed but still referenced later in the code, which will cause a runtime error. I've left a specific comment detailing the problem and how to resolve it. The accompanying documentation change is correct.
It included a |
|
@dahlia I adjusted the description, too |
|
The latest push to this pull request has been published to JSR and npm as a pre-release:
|
|
There is the |
|
Ah good find! It was because I used an url to initialize the context and not the Request itself. Fixed. Thanks! |
Summary
The change is just a modification of the tutorial. It included a "getObject" function on the context, which does not exist. I adapted it accordingly.