Skip to content

chore: correct Zed configuration for Deno LSP - #405

Merged
dahlia merged 1 commit into
fedify-dev:mainfrom
moreal:zed-settings
Sep 3, 2025
Merged

chore: correct Zed configuration for Deno LSP#405
dahlia merged 1 commit into
fedify-dev:mainfrom
moreal:zed-settings

Conversation

@moreal

@moreal moreal commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

Summary

This pull request just modifies only .zed/settings.json to correct Zed configuration for Deno LSP.

Related Issue

There is no related issue.

Changes

Changes of this pull request is very simple:

-  "deno": {
-    "enable": true,
-    "unstable": true
+  "lsp": {
+    "deno": {
+      "settings": {
+        "deno": {
+          "enable": true,
+          "unstable": true
+        }
+      }
+    }

Benefits

While it worked previously, there's no real benefit to this change, but we'll use the proper configuration. Setting deno.enable to false still enables Deno LSP, but changing the enable setting in the modified configuration to false appears to disable it.

Checklist

  • Did you add a changelog entry to the CHANGES.md?
    • This pull request doesn't change anything for Fedify-related packages.
  • Did you write some relevant docs about this change (if it's a new feature)?
    • This pull request doesn't introduce any new features.
  • Did you write a regression test to reproduce the bug (if it's a bug fix)?
      • This pull request doesn't fix any bugs.
  • Did you write some tests for this change (if it's a new feature)?
    • This pull request doesn't introduce any new features.
  • Did you run deno task test-all on your machine?

Additional Notes

Refer:

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @moreal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the configuration for Deno's Language Server Protocol (LSP) within the Zed editor. While the previous setup was functional, this change adopts the officially recommended and more robust configuration structure, ensuring future compatibility and explicit control over LSP features.

Highlights

  • Zed Configuration Correction: The .zed/settings.json file has been updated to align with the correct nested structure for Deno LSP configuration, moving deno.enable and deno.unstable into lsp.deno.settings.deno. This ensures proper control over Deno LSP behavior within the Zed editor.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the Zed editor's settings for the Deno LSP. By moving the Deno configuration under the lsp key, it aligns with the documented and correct structure. This is a good maintenance change that improves the project's development environment configuration. The change is straightforward and looks good.

@github-actions github-actions Bot added runtime/deno Deno runtime related status/ready for review Ready for review type/chore labels Sep 3, 2025
@dahlia
dahlia merged commit 03aa2f4 into fedify-dev:main Sep 3, 2025
9 checks passed
@github-actions

github-actions Bot commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

The latest push to this pull request has been published to JSR and npm as a pre-release:

Package Version JSR npm
@fedify/fedify 1.9.0-pr.405.1518+b1b785a0 JSR npm
@fedify/cli 1.9.0-pr.405.1518+b1b785a0 JSR
@fedify/amqp 1.9.0-pr.405.1518+b1b785a0 JSR npm
@fedify/cfworkers 1.9.0-pr.405.1518+b1b785a0 JSR npm
@fedify/denokv 1.9.0-pr.405.1518+b1b785a0 JSR
@fedify/elysia 1.9.0-pr.405.1518+b1b785a0 npm
@fedify/express 1.9.0-pr.405.1518+b1b785a0 JSR npm
@fedify/h3 1.9.0-pr.405.1518+b1b785a0 JSR npm
@fedify/hono 1.9.0-pr.405.1518+b1b785a0 JSR npm
@fedify/nestjs 1.9.0-pr.405.1518+b1b785a0 npm
@fedify/next 1.9.0-pr.405.1518+b1b785a0 npm
@fedify/postgres 1.9.0-pr.405.1518+b1b785a0 JSR npm
@fedify/redis 1.9.0-pr.405.1518+b1b785a0 JSR npm
@fedify/sqlite 1.9.0-pr.405.1518+b1b785a0 JSR npm
@fedify/sveltekit 1.9.0-pr.405.1518+b1b785a0 JSR npm
@fedify/testing 1.9.0-pr.405.1518+b1b785a0 JSR npm

@github-actions

github-actions Bot commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

The docs for this pull request have been published:

https://ee8bcd65.fedify.pages.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

runtime/deno Deno runtime related status/ready for review Ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants