Skip to content

type: extend Link type and ResourceDescriptor #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dahlia merged 5 commits into from
Sep 3, 2025
Merged

type: extend Link type and ResourceDescriptor #404

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bf33136
type: add template field and make href optional
dodok8 Sep 2, 2025
bb0f803
fix: type error due to href becomes optional
dodok8 Sep 2, 2025
d222232
docs: update packages/fedify/src/webfinger/jrd.ts
dodok8 Sep 2, 2025
9164476
docs: update packages/fedify/src/webfinger/jrd.ts
dodok8 Sep 2, 2025
d1cab13
docs: update changelog
dodok8 Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/fedify/src/nodeinfo/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ export async function getNodeInfo(
"href" in link &&
link.href != null
);
if (link == null) {
if (link == null || link.href == null) {
Comment thread
dahlia marked this conversation as resolved.
logger.error(
"Failed to find a NodeInfo document link from {url}: {resourceDescriptor}",
{ url: wellKnownUrl.href, resourceDescriptor: wellKnownRd },
Expand Down
2 changes: 1 addition & 1 deletion packages/fedify/src/vocab/lookup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ async function lookupObjectInternal(
l.type !== "application/activity+json" &&
!l.type?.match(
/application\/ld\+json;\s*profile="https:\/\/www.w3.org\/ns\/activitystreams"/,
) || l.rel !== "self"
) || l.rel !== "self" || l.href == null
) continue;
try {
const remoteDoc = await documentLoader(l.href, {
Expand Down
10 changes: 9 additions & 1 deletion packages/fedify/src/webfinger/jrd.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export interface Link {
/**
* A URI pointing to the target resource.
*/
href: string;
href?: string;

/**
* Human-readable titles describing the link relation. If the language is
Expand All @@ -56,4 +56,12 @@ export interface Link {
* Conveys additional information about the link relation.
*/
properties?: Record<string, string>;

/**
* A URI Template (RFC 6570) that can be used to construct URIs by
* substituting variables. Used primarily for subscription endpoints
* where parameters like account URIs need to be dynamically inserted.
Comment thread
dodok8 marked this conversation as resolved.
* @since 1.9.0
*/
template?: string;
}
Loading